Bug 9696

Summary: Remove YUI styling from buttons on patron card creator edit pages
Product: Koha Reporter: Owen Leonard <oleonard>
Component: TemplatesAssignee: Owen Leonard <oleonard>
Status: CLOSED FIXED QA Contact: Katrin Fischer <katrin.fischer>
Severity: enhancement    
Priority: P5 - low CC: bgkriegel, katrin.fischer
Version: Main   
Hardware: All   
OS: All   
URL: /cgi-bin/koha/patroncards/edit-*.pl
Change sponsored?: --- Patch complexity: ---
Documentation contact: Documentation submission:
Text to go in the release notes:
Version(s) released in:
Bug Depends on:    
Bug Blocks: 9697    
Attachments: Bug 9696 - Remove YUI styling from buttons on patron card creator edit pages
[SIGNED-OFF] Bug 9696 - Remove YUI styling from buttons on patron card creator edit pages
[PASSED QA] Bug 9696 - Remove YUI styling from buttons on patron card creator edit pages

Description Owen Leonard 2013-02-22 14:51:05 UTC
Some buttons on the patron card creator's edit pages are styled using YUI:

/cgi-bin/koha/patroncards/edit-batch.pl
/cgi-bin/koha/patroncards/edit-layout.pl
/cgi-bin/koha/patroncards/edit-profile.pl
/cgi-bin/koha/patroncards/edit-template.pl

Typically we don't apply special button styling to submit buttons, so to make these pages consistent with others in Koha I propose to remove YUI styling.
Comment 1 Owen Leonard 2013-02-22 14:55:17 UTC Comment hidden (obsolete)
Comment 2 Bernardo Gonzalez Kriegel 2013-02-22 19:58:41 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2013-03-05 07:07:25 UTC
Created attachment 15872 [details] [review]
[PASSED QA] Bug 9696 - Remove YUI styling from buttons on patron card creator edit pages

Submit and cancel buttons on patron card creator edit pages should not
be styled differently than other submit and cancel controls.

This patch removes YUI styling of these controls and makes them
consistent with controls on other Koha pages. The "Cancel" button has
been removed altogether from the batch edit page since there is not a
corresponding submit button.

To test, got to the patron card creator and edit a batch, a layout, a
profile, and a template. Submit and cancel controls should look correct
and work correctly.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>

Comment: Work as described. Works and looks well. No errors.

Note: It's true that edit batch has not a submit button, but
on the other managed pages (layout, profile, template) cancel
aborts editing and takes you to a list of objects (layout, etc.)
Now if we selected the wrong batch, we need to click on left menu o
back button (yay). Are we loosing a consistent interface?
Just thinking.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works as described, more consistent with Koha's general interface
patterns.
Comment 4 Jared Camins-Esakov 2013-03-07 14:55:34 UTC
This patch has been pushed to master.