Summary: | Remove changelanguage.pl in favor of (already present) opac-changelanguage.pl | ||
---|---|---|---|
Product: | Koha | Reporter: | Tomás Cohen Arazi <tomascohen> |
Component: | OPAC | Assignee: | Tomás Cohen Arazi <tomascohen> |
Status: | CLOSED FIXED | QA Contact: | Jonathan Druart <jonathan.druart> |
Severity: | normal | ||
Priority: | P5 - low | CC: | chris, jonathan.druart |
Version: | Main | ||
Hardware: | All | ||
OS: | All | ||
Change sponsored?: | Sponsored | Patch complexity: | Trivial patch |
Documentation contact: | Documentation submission: | ||
Text to go in the release notes: | Version(s) released in: | ||
Bug Depends on: | |||
Bug Blocks: | 9733 | ||
Attachments: |
Bug 9731 - Remove changelanguage.pl in favor of (already present) opac-changelanguage.pl
[SIGNED-OFF] Bug 9731 - Remove changelanguage.pl in favor of opac-changelanguage.pl [SIGNED-OFF] Bug 9731 - Remove changelanguage.pl in favor of opac-changelanguage.pl Bug 9731 - Remove changelanguage.pl in favor of opac-changelanguage.pl Bug 9731 - Remove changelanguage.pl in favor of opac-changelanguage.pl |
Description
Tomás Cohen Arazi
2013-02-28 15:19:28 UTC
Created attachment 15772 [details] [review] Bug 9731 - Remove changelanguage.pl in favor of (already present) opac-changelanguage.pl Remove that file that duplicates the behaviour of the correct opac-changelanguage.pl file and fix references to it in the templates. To+ Sponsored-by: Universidad Nacional de Córdoba To test: - Apply the patch - Choose a different language in the OPAC - It should work as expected. Created attachment 16267 [details] [review] [SIGNED-OFF] Bug 9731 - Remove changelanguage.pl in favor of opac-changelanguage.pl Remove that file that duplicates the behaviour of the correct opac-changelanguage.pl file and fix references to it in the templates. To test: - Apply the patch - Choose a different language in the OPAC - It should work as expected. To+ Sponsored-by: Universidad Nacional de Córdoba Signed-off-by: Owen Leonard <oleonard@myacpl.org> fatal: cannot convert from UTF-8utf-8 to UTF-8 Owen, your submitted patch is bad-formatted, please resubmit it. Created attachment 16273 [details] [review] [SIGNED-OFF] Bug 9731 - Remove changelanguage.pl in favor of opac-changelanguage.pl Remove that file that duplicates the behaviour of the correct opac-changelanguage.pl file and fix references to it in the templates. To test: - Apply the patch - Choose a different language in the OPAC - It should work as expected. To+ Sponsored-by: Universidad Nacional de Córdoba Signed-off-by: Owen Leonard <oleonard@myacpl.org> QA comment: This patch replaces all occurrences of opac/changelanguage.pl with opac/opac-changelanguage.pl. These 2 scripts do the same job, it is useless to have both. Marked as Passed QA. Created attachment 16318 [details] [review] Bug 9731 - Remove changelanguage.pl in favor of opac-changelanguage.pl Remove that file that duplicates the behaviour of the correct opac-changelanguage.pl file and fix references to it in the templates. To test: - Apply the patch - Choose a different language in the OPAC - It should work as expected. To+ Sponsored-by: Universidad Nacional de Córdoba Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Created attachment 16451 [details] [review] Bug 9731 - Remove changelanguage.pl in favor of opac-changelanguage.pl Remove that file that duplicates the behaviour of the correct opac-changelanguage.pl file and fix references to it in the templates. To test: - Apply the patch - Choose a different language in the OPAC - It should work as expected. To+ Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Tested again at RM's request Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> This patch has been pushed to master. |