Bug 9731 - Remove changelanguage.pl in favor of (already present) opac-changelanguage.pl
Summary: Remove changelanguage.pl in favor of (already present) opac-changelanguage.pl
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Tomás Cohen Arazi
QA Contact: Jonathan Druart
URL:
Keywords:
Depends on:
Blocks: 9733
  Show dependency treegraph
 
Reported: 2013-02-28 15:19 UTC by Tomás Cohen Arazi
Modified: 2014-05-26 21:04 UTC (History)
2 users (show)

See Also:
Change sponsored?: Sponsored
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 9731 - Remove changelanguage.pl in favor of (already present) opac-changelanguage.pl (6.46 KB, patch)
2013-02-28 15:22 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 9731 - Remove changelanguage.pl in favor of opac-changelanguage.pl (6.64 KB, patch)
2013-03-18 15:33 UTC, Owen Leonard
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 9731 - Remove changelanguage.pl in favor of opac-changelanguage.pl (6.60 KB, patch)
2013-03-18 16:00 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 9731 - Remove changelanguage.pl in favor of opac-changelanguage.pl (6.65 KB, patch)
2013-03-19 08:15 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 9731 - Remove changelanguage.pl in favor of opac-changelanguage.pl (6.64 KB, patch)
2013-03-20 01:48 UTC, Chris Cormack
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Tomás Cohen Arazi 2013-02-28 15:19:28 UTC

    
Comment 1 Tomás Cohen Arazi 2013-02-28 15:22:13 UTC Comment hidden (obsolete)
Comment 2 Tomás Cohen Arazi 2013-03-18 15:10:51 UTC
To test:
- Apply the patch
- Choose a different language in the OPAC
- It should work as expected.
Comment 3 Owen Leonard 2013-03-18 15:33:10 UTC Comment hidden (obsolete)
Comment 4 Jonathan Druart 2013-03-18 15:47:01 UTC
fatal: cannot convert from UTF-8utf-8 to UTF-8

Owen, your submitted patch is bad-formatted, please resubmit it.
Comment 5 Owen Leonard 2013-03-18 16:00:22 UTC Comment hidden (obsolete)
Comment 6 Jonathan Druart 2013-03-19 08:15:24 UTC
QA comment:
This patch replaces all occurrences of opac/changelanguage.pl with opac/opac-changelanguage.pl.
These 2 scripts do the same job, it is useless to have both.
Marked as Passed QA.
Comment 7 Jonathan Druart 2013-03-19 08:15:36 UTC Comment hidden (obsolete)
Comment 8 Chris Cormack 2013-03-20 01:48:42 UTC
Created attachment 16451 [details] [review]
Bug 9731 - Remove changelanguage.pl in favor of opac-changelanguage.pl

Remove that file that duplicates the behaviour of the correct
opac-changelanguage.pl file and fix references to it in the templates.

To test:
- Apply the patch
- Choose a different language in the OPAC
- It should work as expected.

To+

Sponsored-by: Universidad Nacional de Cordoba
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>

Tested again at RM's request

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Comment 9 Jared Camins-Esakov 2013-03-20 01:52:04 UTC
This patch has been pushed to master.