Bug 10002 - Don't include line breaks in strings that are translated
Summary: Don't include line breaks in strings that are translated
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial (vote)
Assignee: Owen Leonard
QA Contact: Jonathan Druart
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-08 14:57 UTC by Katrin Fischer
Modified: 2014-05-26 21:04 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: String patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 10002 - Don't include line breaks in strings that are translated (2.69 KB, patch)
2013-04-09 19:55 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 10002 - Don't include line breaks in strings that are translated (2.77 KB, patch)
2013-04-09 21:49 UTC, Chris Cormack
Details | Diff | Splinter Review
Bug 10002 - Don't include line breaks in strings that are translated (2.83 KB, patch)
2013-04-10 12:33 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2013-04-08 14:57:45 UTC
Because Pootle will add in additional escaping and because it's confusing to translators, we should not include formatting/line breaks in strings for translation.

cat-toolbar.inc:
holds(s) for this record \\n Are you sure you want to delete this record?.

Also, we shoudl fix the typo.
Comment 1 Owen Leonard 2013-04-09 19:55:09 UTC Comment hidden (obsolete)
Comment 2 Chris Cormack 2013-04-09 21:49:28 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2013-04-10 12:33:34 UTC
Created attachment 17340 [details] [review]
Bug 10002 - Don't include line breaks in strings that are translated

Several JS alert messages contain "\n" which is problematic for
translation. This patch removes those instances (a line break is not
strictly necessary anyway). Also corrected: two instances of "holds(s)"

To test, place a hold on a title with items. From the biblio detail page
choose Edit -> Delete all items and Edit -> Delete record. In each case
you should see error messages with no line breaks and no misspellings.

Delete all items attached to the record with holds from the item edit
page. Go back to the detail page and choose Edit -> Delete record. You
should see an error message about existing hold(s) with no line breaks
or misspellings.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

Harmless change, fixes misspellings and makes translations easier

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 4 Jared Camins-Esakov 2013-04-18 13:12:30 UTC
This patch has been pushed to master and 3.12.x.
Comment 5 Chris Cormack 2013-04-27 05:25:42 UTC
Pushed to 3.10.x will be in 3.10.6