Bug 10006 - holding branch is not available to XSLT display
Summary: holding branch is not available to XSLT display
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial (vote)
Assignee: Liz Rea
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-09 01:46 UTC by Liz Rea
Modified: 2014-05-26 21:04 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
XSL file to use while testing (65.47 KB, application/xslt+xml)
2013-04-09 03:43 UTC, Liz Rea
Details
Bug 10006 - holding branch is not available to XSLT display (1.68 KB, patch)
2013-04-09 03:47 UTC, Liz Rea
Details | Diff | Splinter Review
Bug 10006 - holding branch is not available to XSLT display (1.75 KB, patch)
2013-04-12 12:37 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 10006 - holding branch is not available to XSLT display (1.85 KB, patch)
2013-04-22 12:55 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Liz Rea 2013-04-09 01:46:33 UTC
People who want to show the holding branch in results or details in XSLT currently cannot do it, and I think they should be able to.
Comment 1 Liz Rea 2013-04-09 03:43:55 UTC
Created attachment 17300 [details]
XSL file to use while testing

This XSLT file will show the holding branch instead of the home branch on the OPAC results.

It will need to be put in the same folder with MARC21slimUtils.xsl OR you will need to update the path to MARC21slimutils.xsl in this XSLT so that it can find it's references.
Comment 2 Liz Rea 2013-04-09 03:47:09 UTC Comment hidden (obsolete)
Comment 3 Liz Rea 2013-04-09 03:50:37 UTC
Do note, the xslt file is *not* part of the patch. It is only for testing purposes.
Comment 4 Kyle M Hall 2013-04-12 12:37:27 UTC Comment hidden (obsolete)
Comment 5 Marcel de Rooy 2013-04-22 12:55:58 UTC
Created attachment 17592 [details] [review]
Bug 10006 - holding branch is not available to XSLT display

To test:

Use attached XSLT stylesheet for OPAC Results
 * set your OPACXSLTResultsDisplay to use the attached stylesheet. The path is the FULL PATH, from /, to the file.
 * be sure to copy MARC21slimUtils.xsl to the same folder, or change the path in the attached one to point to the correct path on your filesystem.

Verify that the OPAC results now show the holding branch instead of the home branch.

Possible fail states:

* no branch is shown (only call numbers, if given)
* the wrong branch is shown

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 6 Marcel de Rooy 2013-04-22 12:58:06 UTC
QA Comment:
Looks good to me. Works as advertised; tested by editing opacresults. No complaints from qa tools.

Passed QA
Comment 7 Jared Camins-Esakov 2013-04-26 02:14:46 UTC
This patch has been pushed to master and 3.12.x.
Comment 8 Chris Cormack 2013-04-27 21:36:21 UTC
Patch doesn't apply on 3.10.x please send a new patch if it is needed