Bug 10008 - Serials search results 'Opened' tab should be 'Open'
Summary: Serials search results 'Opened' tab should be 'Open'
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial
Assignee: Owen Leonard
QA Contact: Jonathan Druart
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-09 12:38 UTC by Katrin Fischer
Modified: 2014-05-26 21:04 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: String patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 10008 - Serials search results 'Opened' tab should be 'Open' (2.64 KB, patch)
2013-04-09 19:34 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 10008 - Serials search results 'Opened' tab should be 'Open' (2.66 KB, patch)
2013-04-09 21:52 UTC, Chris Cormack
Details | Diff | Splinter Review
Bug 10008 - Serials search results 'Opened' tab should be 'Open' (2.72 KB, patch)
2013-04-10 12:14 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2013-04-09 12:38:51 UTC
After asking native speaker advice I think that the tabs on the serials subscription search page should be labelled "open" and "closed".
Comment 1 Owen Leonard 2013-04-09 19:34:23 UTC Comment hidden (obsolete)
Comment 2 Chris Cormack 2013-04-09 21:52:13 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2013-04-10 12:14:45 UTC
Created attachment 17339 [details] [review]
Bug 10008 - Serials search results 'Opened' tab should be 'Open'

The searials search results "Opened" tab should be labeled "Open." This
patch makes this correction and changes the wording in another place
which used "opened." Markup has also been added to maintain consistency
in display of messages.

To test, perform a search for a subscription. If your search returns
results you should see an "Open" and a "Closed" tab. To test other
affected changes perform searches which return no results, only open
subscriptions, or only closed subscriptions. "No results" messages
should display correctly and consistently.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 4 Jared Camins-Esakov 2013-04-18 12:59:23 UTC
This patch has been pushed to master and 3.12.x.
Comment 5 Chris Cormack 2013-04-27 05:28:38 UTC
Doesn't apply to 3.10.x
Comment 6 Jonathan Druart 2013-04-29 07:17:39 UTC
The string does not exist in the 3.10.x branch.