Created attachment 17310 [details] Screenshot of proposed revised interface Display of the three sections of subfield constraints (basic, advanced, and other) is well-suited to the jQueryUI Accordion widget.
Created attachment 17312 [details] [review] Bug 10010 - Use jQueryUI Accordion to display constraints in MARC subfield editor The jQueryUI Accordion widget, included by default in Koha, is well-suited to handle the kind of show/hide actions which are used in the MARC subfield editor. This patch replaces the custom-writted JS with jQueryUI JS and markup. To test, load the tag subfield editor: Admin -> MARC frameworks -> MARC structure -> Subfields -> Edit. Confirm that basic, advanced, and other contraints panels are show/hidden correctly. Confirm that tabs work, and that edit operations are not disrupted.
Created attachment 17382 [details] [review] Bug 10010 - Use jQueryUI Accordion to display constraints in MARC subfield editor The jQueryUI Accordion widget, included by default in Koha, is well-suited to handle the kind of show/hide actions which are used in the MARC subfield editor. This patch replaces the custom-writted JS with jQueryUI JS and markup. To test, load the tag subfield editor: Admin -> MARC frameworks -> MARC structure -> Subfields -> Edit. Confirm that basic, advanced, and other contraints panels are show/hidden correctly. Confirm that tabs work, and that edit operations are not disrupted. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 17679 [details] [review] Bug 10010: Problems with diacritics in saved SQL reports Adds decoding for cgi params (for completeness). Apparently, the NAME attribute of DBI statement handle has a UTF8 bug. Fixing this by decoding the returned column names. Did this in a shared routine.
Comment on attachment 17679 [details] [review] Bug 10010: Problems with diacritics in saved SQL reports Oops wrong report..
CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc_subfields_structure.tt
Created attachment 18943 [details] [review] [SIGNED-OFF] Bug 10010 - Use jQueryUI Accordion to display constraints in MARC subfield editor The jQueryUI Accordion widget, included by default in Koha, is well-suited to handle the kind of show/hide actions which are used in the MARC subfield editor. This patch replaces the custom-writted JS with jQueryUI JS and markup. To test, load the tag subfield editor: Admin -> MARC frameworks -> MARC structure -> Subfields -> Edit. Confirm that basic, advanced, and other contraints panels are show/hidden correctly. Confirm that tabs work, and that edit operations are not disrupted. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Created attachment 19048 [details] [review] [PASSED QA] Bug 10010 - Use jQueryUI Accordion to display constraints in MARC subfield editor The jQueryUI Accordion widget, included by default in Koha, is well-suited to handle the kind of show/hide actions which are used in the MARC subfield editor. This patch replaces the custom-writted JS with jQueryUI JS and markup. To test, load the tag subfield editor: Admin -> MARC frameworks -> MARC structure -> Subfields -> Edit. Confirm that basic, advanced, and other contraints panels are show/hidden correctly. Confirm that tabs work, and that edit operations are not disrupted. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Looks nice, passes all tests and QA script.
Nice work Owen! Can we also get a patch for the authority frameworks? :)
Katrin, reading the history, it seems you did not mean to switch back to 'Signed Off'. Could you confirm this patch had passed QA?
You are right, thx Jonathan! It happens sometimes when using git bz that the status pulldown in bugzilla is still on the old status... then you add a comment and it's resetting.
Pushed to master. Thanks, Owen!