Bug 10010 - Use jQueryUI Accordion to display constraints in MARC subfield editor
Summary: Use jQueryUI Accordion to display constraints in MARC subfield editor
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: System Administration (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact:
URL: /cgi-bin/koha/admin/marc_subfields_st...
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-09 14:34 UTC by Owen Leonard
Modified: 2014-12-07 20:02 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Screenshot of proposed revised interface (27.34 KB, image/png)
2013-04-09 14:34 UTC, Owen Leonard
Details
Bug 10010 - Use jQueryUI Accordion to display constraints in MARC subfield editor (7.17 KB, patch)
2013-04-09 14:58 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 10010 - Use jQueryUI Accordion to display constraints in MARC subfield editor (7.19 KB, patch)
2013-04-12 12:33 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 10010: Problems with diacritics in saved SQL reports (2.03 KB, patch)
2013-04-25 12:42 UTC, Marcel de Rooy
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 10010 - Use jQueryUI Accordion to display constraints in MARC subfield editor (6.66 KB, patch)
2013-06-13 15:42 UTC, Owen Leonard
Details | Diff | Splinter Review
[PASSED QA] Bug 10010 - Use jQueryUI Accordion to display constraints in MARC subfield editor (6.73 KB, patch)
2013-06-16 19:44 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2013-04-09 14:34:29 UTC
Created attachment 17310 [details]
Screenshot of proposed revised interface

Display of the three sections of subfield constraints (basic, advanced, and other) is well-suited to the jQueryUI Accordion widget.
Comment 1 Owen Leonard 2013-04-09 14:58:21 UTC Comment hidden (obsolete)
Comment 2 Kyle M Hall 2013-04-12 12:33:31 UTC Comment hidden (obsolete)
Comment 3 Marcel de Rooy 2013-04-25 12:42:01 UTC Comment hidden (obsolete)
Comment 4 Marcel de Rooy 2013-04-25 12:43:02 UTC
Comment on attachment 17679 [details] [review]
Bug 10010: Problems with diacritics in saved SQL reports

Oops wrong report..
Comment 5 Jonathan Druart 2013-05-03 08:13:03 UTC
CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc_subfields_structure.tt
Comment 6 Owen Leonard 2013-06-13 15:42:13 UTC Comment hidden (obsolete)
Comment 7 Katrin Fischer 2013-06-16 19:44:21 UTC
Created attachment 19048 [details] [review]
[PASSED QA] Bug 10010 - Use jQueryUI Accordion to display constraints in MARC subfield editor

The jQueryUI Accordion widget, included by default in Koha, is
well-suited to handle the kind of show/hide actions which are used in
the MARC subfield editor. This patch replaces the custom-writted JS with
jQueryUI JS and markup.

To test, load the tag subfield editor: Admin -> MARC frameworks -> MARC
structure -> Subfields -> Edit. Confirm that basic, advanced, and other
contraints panels are show/hidden correctly. Confirm that tabs work, and
that edit operations are not disrupted.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Looks nice, passes all tests and QA script.
Comment 8 Katrin Fischer 2013-06-16 19:45:53 UTC
Nice work Owen! Can we also get a patch for the authority frameworks? :)
Comment 9 Jonathan Druart 2013-06-20 07:47:53 UTC
Katrin, reading the history, it seems you did not mean to switch back to 'Signed Off'. Could you confirm this patch had passed QA?
Comment 10 Katrin Fischer 2013-06-20 08:02:56 UTC
You are right, thx Jonathan! It happens sometimes when using git bz that the status pulldown in bugzilla is still on the old status... then you add a comment and it's resetting.
Comment 11 Galen Charlton 2013-06-20 14:43:01 UTC
Pushed to master.  Thanks, Owen!