Created attachment 17375 [details] the page supposed to have the close basket button and change basket group area I used the demo site 3.10 to run some tests. when i created a basket and finished placing order, i can't find the close basket button on top and the change basket group area.
I looked at your screenshot and I think the problem here is uncertain prices. You are not allowed to close a basket with uncertain prices, so the button is hidden until that is resolved. Maybe it would it would be better to show the button greyed out with an explaining tooltip. Thank you for the report :)
Created attachment 69748 [details] [review] Added disabled "Close this basket" button when uncertain prices are present. Note that whilst this has a "title" attribute, there is no tooltip shown because JQueryUI disabled buttons don't get DOM events.
Hi Jon, could you add a step-by-step test plan to this? Then this might make a good 'Academy' bug.
OK, how about this for a test plan: 1) Before applying the patch, go to staff UI, and select Acquisitions, pick one of your existing vendors (or create a new one) and then open a new basket (call it anything you want). 2) Add a new (empty) record order to the basket. 3) Give the new record a made up title, add a single item (no need to fill in any details), set a price of 10.00 and check the "Uncertain price" checkbox before saving the record. 4) Confirm that the resulting summary page has a button bar that does NOT include any button for closing the basket. 5) Modify the record and remove the check mark from the "Uncertain price" checkbox before saving. 6) Confirm that the resulting basket summary page button bar now does have a "Close this basket" button (as the basket no longer has uncertain prices). 7) Apply the patch. 8) Modify the record again to check the "Uncertain price" checkbox again, then save it. 9) Confirm that the resulting summary page has a button bar that does include a "Close this basket" button but that this button is greyed out and inoperative. 10) Modify the record again to remove the check mark in the "Uncertain price" checkbox, then save the record. 11) Confirm that the resulting summary page has a button bar that does include a "Close this basket" button which is now active (as the order no longer has an uncertain price).
Thx, Jon!
Created attachment 70250 [details] [review] Bug 10032: Uncertain prices hide 'close basket' without explanation Added disabled "Close this basket" button when uncertain prices are present. Note that whilst this has a "title" attribute, there is no tooltip shown because JQueryUI disabled buttons don't get DOM events. To test: 1) Before applying the patch, go to staff UI, and select Acquisitions, pick one of your existing vendors (or create a new one) and then open a new basket (call it anything you want). 2) Add a new (empty) record order to the basket. 3) Give the new record a made up title, add a single item (no need to fill in any details), set a price of 10.00 and check the "Uncertain price" checkbox before saving the record. 4) Confirm that the resulting summary page has a button bar that does NOT include any button for closing the basket. 5) Modify the record and remove the check mark from the "Uncertain price" checkbox before saving. 6) Confirm that the resulting basket summary page button bar now does have a "Close this basket" button (as the basket no longer has uncertain prices). 7) Apply the patch. 8) Modify the record again to check the "Uncertain price" checkbox again, then save it. 9) Confirm that the resulting summary page has a button bar that does include a "Close this basket" button but that this button is greyed out and inoperative. 10) Modify the record again to remove the check mark in the "Uncertain price" checkbox, then save the record. 11) Confirm that the resulting summary page has a button bar that does include a "Close this basket" button which is now active (as the order no longer has an uncertain price).
Created attachment 70272 [details] [review] Bug 10032: (Follow-up) Move title attribute to button container This patch modifies the "Close basket" button markup so that the title attribute on a disabled button is added to the button wrapper <div> instead of the <a> tag. This allows the title attribute tooltip to appear when the cursor is hovered over the button. To test, follow the original patch's test plan and confirm that when the "Close basket" button is disabled, hovering the mouse over the button triggers the title attribute tooltip.
Created attachment 70526 [details] [review] Added disabled "Close this basket" button when uncertain prices are present. Note that whilst this has a "title" attribute, there is no tooltip shown because JQueryUI disabled buttons don't get DOM events. https://bugs.koha-community.org/show_bug.cgi?id=10032 Signed-off-by: Charlotte Cordwell <charlotte.cordwell123@gmail.com>
Created attachment 70527 [details] [review] Bug 10032: (Follow-up) Move title attribute to button container This patch modifies the "Close basket" button markup so that the title attribute on a disabled button is added to the button wrapper <div> instead of the <a> tag. This allows the title attribute tooltip to appear when the cursor is hovered over the button. To test, follow the original patch's test plan and confirm that when the "Close basket" button is disabled, hovering the mouse over the button triggers the title attribute tooltip. Signed-off-by: Charlotte Cordwell <charlotte.cordwell123@gmail.com>
Owen, I think you had a fix somewhere for the missing tooltip, but couldn't find the bug. Can you have a look maybe?
The title is already helpful and a clear improvement over the 'vanishing' of the button. Moving to PQA with the option of a later follow-up.
Created attachment 71242 [details] [review] Bug 10032: Improve GUI when uncertain price prevents closing the basket Added disabled "Close this basket" button when uncertain prices are present. Note that whilst this has a "title" attribute, there is no tooltip shown because JQueryUI disabled buttons don't get DOM events. https://bugs.koha-community.org/show_bug.cgi?id=10032 Signed-off-by: Charlotte Cordwell <charlotte.cordwell123@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 71243 [details] [review] Bug 10032: (follow-up) Move title attribute to button container This patch modifies the "Close basket" button markup so that the title attribute on a disabled button is added to the button wrapper <div> instead of the <a> tag. This allows the title attribute tooltip to appear when the cursor is hovered over the button. To test, follow the original patch's test plan and confirm that when the "Close basket" button is disabled, hovering the mouse over the button triggers the title attribute tooltip. Signed-off-by: Charlotte Cordwell <charlotte.cordwell123@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Pushed to master for 18.05, thanks to everybody involved!