Bug 10036 - adding header search to additem page
Summary: adding header search to additem page
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Jonathan Druart
URL:
Keywords:
: 9741 (view as bug list)
Depends on:
Blocks:
 
Reported: 2013-04-13 14:35 UTC by Mathieu Saby
Modified: 2014-12-07 20:02 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
capture1 : a record in normal view (204.39 KB, image/jpeg)
2013-04-13 17:56 UTC, Mathieu Saby
Details
capture2 : items of a record (337.83 KB, image/jpeg)
2013-04-13 17:57 UTC, Mathieu Saby
Details
Bug 10036 - adding header search to additem page (1.25 KB, patch)
2013-04-30 19:38 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 10036 - adding header search to additem page (1.28 KB, patch)
2013-05-03 17:11 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 10036 - adding header search to additem page (1.34 KB, patch)
2013-05-23 11:51 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Mathieu Saby 2013-04-13 14:35:56 UTC
In cataloguing/additem.pl, the header is missing : we need Koha's logo and the header search forms

M. Saby
Comment 1 Katrin Fischer 2013-04-13 17:19:15 UTC
Hi Mathieu, Owen told me it was by design to have more room for large item tables. I was irritated too, but I think it could make sense on this page. What do you think?
Comment 2 Mathieu Saby 2013-04-13 17:55:36 UTC
Hello Katrin
Owen's argument is interesting, but it could be applied to all pages ;-)
For example, even in Normal view, I need to scroll to see the items of some records (because I have some toolbars in my firefox, and a bottom Koha bar to change language...).
The header takes a lot of space is taken on each page.
Maybe a solution would be to reduce its height on all pages?
Or maybe to make it "sticky", so that it would always be usable even if we scroll down the page?

See capture1 : a serial record in Rennes 2 Koha ; you cannot see the items
See capture2 : the items of this serial. Even without header, you cannot see all items (more than 100...).

Regarding additem, displaying ALL the items linked to a record is sometimes not a good idea. Maybe we could display only x (10? or a value in a syspref?) items, and hide the other with CSS, with a button/link for showing more?

I don't have a solution, but I am sure this page could be improved...

Mathieu
Comment 3 Mathieu Saby 2013-04-13 17:56:44 UTC
Created attachment 17408 [details]
capture1 : a record in normal view
Comment 4 Mathieu Saby 2013-04-13 17:57:17 UTC
Created attachment 17409 [details]
capture2 : items of a record
Comment 5 Mathieu Saby 2013-04-14 12:49:24 UTC
See also BZ 7508 : "It would be nice if on the items detail tab in the staff client you could click a little arrow to collapse the item details so you only see the one or ones you want without having to scroll too much."

M. Saby
Comment 6 Owen Leonard 2013-04-14 13:16:34 UTC
The original idea behind the lack of the search header on the additem page was that the page was narrowly task-oriented and did not need the search header. I don't think this has proven to be true for most people (including me, even in my limited day-to-day use of it), so I have no objection at all to adding it.
Comment 7 Owen Leonard 2013-04-30 19:38:26 UTC Comment hidden (obsolete)
Comment 8 Kyle M Hall 2013-05-03 17:11:01 UTC Comment hidden (obsolete)
Comment 9 Jonathan Druart 2013-05-23 11:51:02 UTC
QA comment:
Simple patch, it adds the header on the add item page.
Marked as Passed QA.
Comment 10 Jonathan Druart 2013-05-23 11:51:14 UTC
Created attachment 18347 [details] [review]
Bug 10036 - adding header search to additem page

The add item screen lacks a header search form. This patch adds the
cataloging header search include to additem.tt.

To test, apply the patch and add items to or edit items of an existing
record. The header search form should appear with options for cataloging
search and circulation.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 11 Galen Charlton 2013-05-23 14:16:10 UTC
Pushed to master.  Thanks, Owen!
Comment 12 Tomás Cohen Arazi 2013-06-03 14:20:15 UTC
This patch has been pushed to 3.12.x, will be in 3.12.1.
Comment 13 Bernardo Gonzalez Kriegel 2013-06-06 00:50:41 UTC
Pushed to 3.10.x, will be in 3.10.7
Comment 14 Chris Hall 2013-06-06 09:45:20 UTC
Pushed to 3.8.x, will be in 3.8.14
Thanks :)
Comment 15 Owen Leonard 2013-08-16 17:41:11 UTC
*** Bug 9741 has been marked as a duplicate of this bug. ***