In cataloguing/additem.pl, the header is missing : we need Koha's logo and the header search forms M. Saby
Hi Mathieu, Owen told me it was by design to have more room for large item tables. I was irritated too, but I think it could make sense on this page. What do you think?
Hello Katrin Owen's argument is interesting, but it could be applied to all pages ;-) For example, even in Normal view, I need to scroll to see the items of some records (because I have some toolbars in my firefox, and a bottom Koha bar to change language...). The header takes a lot of space is taken on each page. Maybe a solution would be to reduce its height on all pages? Or maybe to make it "sticky", so that it would always be usable even if we scroll down the page? See capture1 : a serial record in Rennes 2 Koha ; you cannot see the items See capture2 : the items of this serial. Even without header, you cannot see all items (more than 100...). Regarding additem, displaying ALL the items linked to a record is sometimes not a good idea. Maybe we could display only x (10? or a value in a syspref?) items, and hide the other with CSS, with a button/link for showing more? I don't have a solution, but I am sure this page could be improved... Mathieu
Created attachment 17408 [details] capture1 : a record in normal view
Created attachment 17409 [details] capture2 : items of a record
See also BZ 7508 : "It would be nice if on the items detail tab in the staff client you could click a little arrow to collapse the item details so you only see the one or ones you want without having to scroll too much." M. Saby
The original idea behind the lack of the search header on the additem page was that the page was narrowly task-oriented and did not need the search header. I don't think this has proven to be true for most people (including me, even in my limited day-to-day use of it), so I have no objection at all to adding it.
Created attachment 17854 [details] [review] Bug 10036 - adding header search to additem page The add item screen lacks a header search form. This patch adds the cataloging header search include to additem.tt. To test, apply the patch and add items to or edit items of an existing record. The header search form should appear with options for cataloging search and circulation.
Created attachment 17938 [details] [review] Bug 10036 - adding header search to additem page The add item screen lacks a header search form. This patch adds the cataloging header search include to additem.tt. To test, apply the patch and add items to or edit items of an existing record. The header search form should appear with options for cataloging search and circulation. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
QA comment: Simple patch, it adds the header on the add item page. Marked as Passed QA.
Created attachment 18347 [details] [review] Bug 10036 - adding header search to additem page The add item screen lacks a header search form. This patch adds the cataloging header search include to additem.tt. To test, apply the patch and add items to or edit items of an existing record. The header search form should appear with options for cataloging search and circulation. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Pushed to master. Thanks, Owen!
This patch has been pushed to 3.12.x, will be in 3.12.1.
Pushed to 3.10.x, will be in 3.10.7
Pushed to 3.8.x, will be in 3.8.14 Thanks :)
*** Bug 9741 has been marked as a duplicate of this bug. ***