Bug 10053 - borrowers.branchcode cannot be null
Summary: borrowers.branchcode cannot be null
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Patrons (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Jonathan Druart
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-15 12:26 UTC by Jonathan Druart
Modified: 2013-12-05 20:09 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 10053: borrowers.branchcode cannot be null (1.42 KB, patch)
2013-04-15 12:31 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 10053: borrowers.branchcode cannot be null (1.47 KB, patch)
2013-04-16 10:13 UTC, Chris Cormack
Details | Diff | Splinter Review
Bug 10053: borrowers.branchcode cannot be null (1.57 KB, patch)
2013-04-29 15:44 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2013-04-15 12:26:47 UTC
The DB field borrowers.branchcode cannot be null (`branchcode` varchar(10) NOT NULL default ''). However, an empty value can be selected on creating/updating a patron.
Comment 1 Jonathan Druart 2013-04-15 12:31:47 UTC Comment hidden (obsolete)
Comment 2 Chris Cormack 2013-04-16 10:13:04 UTC Comment hidden (obsolete)
Comment 3 Marcel de Rooy 2013-04-29 15:44:48 UTC
Created attachment 17799 [details] [review]
Bug 10053: borrowers.branchcode cannot be null

The DB field borrowers.branchcode cannot be null (`branchcode`
varchar(10) NOT NULL default ''). However, an empty value can be selected
on creating/updating a patron.

Test plan:
- Add or edit a patron and choose the empty value for library
(branchcode).
- Save (pref BorrowerMandatoryField must not contain branchcode).
- Mysql raises an error.
- Apply the path.
- Check that you are not able to select no library.

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 4 Marcel de Rooy 2013-04-29 15:47:14 UTC
QA Comment:
One line patch solves an error that was not reported in the interface (but seen in the log).

Passed QA
Comment 5 Jared Camins-Esakov 2013-05-01 11:37:44 UTC
This patch has been pushed to master and 3.12.x.
Comment 6 Chris Cormack 2013-05-09 07:09:48 UTC
Does not apply to 3.10.x