Bug 10054 - When SingleBranchMode is enabled, allow superlibrarians to set logged in library
Summary: When SingleBranchMode is enabled, allow superlibrarians to set logged in library
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Kyle M Hall
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-15 13:08 UTC by Kyle M Hall
Modified: 2013-12-05 20:09 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 10054 - When SingleBranchMode is enabled, allow superlibrarians to set logged in library (1.60 KB, patch)
2013-04-15 13:11 UTC, Kyle M Hall
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 10054 - When SingleBranchMode is enabled, allow superlibrarians to set logged in library (2.14 KB, patch)
2013-05-09 18:48 UTC, Owen Leonard
Details | Diff | Splinter Review
[PASSED QA] Bug 10054 - When SingleBranchMode is enabled, allow superlibrarians to set logged in library (2.29 KB, patch)
2013-05-12 10:30 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Kyle M Hall 2013-04-15 13:08:57 UTC
Currently, when SingleBranchMode is enabled, nobody can change the logged in library in Koha. To change it requires disable SingleBranchMode, switching the library, and re-enabling it. It seems reasonable to allow superlibrarians to switch the logged in library even if SingleBranchMode is enabled.
Comment 1 Kyle M Hall 2013-04-15 13:11:32 UTC Comment hidden (obsolete)
Comment 2 Katrin Fischer 2013-04-15 17:32:41 UTC
Hm, but shouldn't you have only one library when singlebranchmode is enabled?
I am asking because we have a bug to remove this system preference altogether: bug 7314
Comment 3 Nicole C. Engard 2013-04-15 18:32:12 UTC
When you log in as the admin user you don't have a branch. As a support company the only user we have is the admin user and when we log in to the system we can't change the branch because of the single branch mode silliness.
Comment 4 Katrin Fischer 2013-04-15 18:49:36 UTC
Hm, we work differently. We have an administration account in each library and only use the database admin account for updating and creating this user.
Comment 5 Katrin Fischer 2013-04-15 18:51:52 UTC
That said - the change looks pretty small, but I was wondering about the use case. :)
Comment 6 Nicole C. Engard 2013-04-15 20:19:44 UTC
How do you prevent the libraries from messing with your user? That's why we use the admin one.

Nicole
Comment 7 Katrin Fischer 2013-04-15 20:33:20 UTC
We don't - they know it's us and don't change it. :)
Comment 8 Owen Leonard 2013-05-09 18:48:15 UTC Comment hidden (obsolete)
Comment 9 Katrin Fischer 2013-05-12 10:30:55 UTC
Created attachment 18093 [details] [review]
[PASSED QA] Bug 10054 - When SingleBranchMode is enabled, allow superlibrarians to set logged in library

Currently, when SingleBranchMode is enabled, nobody can change the
logged in library in Koha. To change it requires disable
SingleBranchMode, switching the library, and re-enabling it. It seems
reasonable to allow superlibrarians to switch the logged in library even
if SingleBranchMode is enabled.

Test Plan:
1) Apply this patch
3) Enable SingleBranchMode
4) Log in as a superlibrarian
5) Attempt to change the logged in branch
   This change should succeed
6) Log in as a non-superlibrarian account
7) Attempt to change the logged n branch
   This should not be allowed, as per Koha's current behavior

Signed-off-by: Owen Leonard <oleonard@myacpl.org>

I guess this doesn't do any harm even though the practical motivations
behind it, as described in the bug, seem otherwise solvable. If
SingleBranchMode is supposed to prevent librarians from switching their
logged in library why can they choose their library when they first log
in? Was SingleBranchMode supposed to only affect the OPAC originally? Or
should the login form be modified? This seems to be a band-aid on a
poorly-implemented feature.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Patch works as decribed. As this only adds a check for a superlibrarian
it seems safe and should not interfere with normal staff accounts.
Comment 10 Katrin Fischer 2013-05-12 10:32:17 UTC
I will open another bug for some inconsistency I found testing this: You can now switch the library once you are logged in, but while the library pull down also shows on the login page, the selection there is not saved.
Comment 11 Jared Camins-Esakov 2013-05-12 14:12:02 UTC
This patch has been pushed to master and 3.12.x.