Bug 10073 - Show ccode or location also if not bound to Authorized Values in XSLT
Summary: Show ccode or location also if not bound to Authorized Values in XSLT
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Marcel de Rooy
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-18 08:05 UTC by Marcel de Rooy
Modified: 2014-05-26 21:04 UTC (History)
0 users

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 10073: Show ccode or location also if not bound to Authorized Values in XSLT (2.04 KB, patch)
2013-04-18 08:12 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 10073: Show ccode or location also if not bound to Authorized Values in XSLT (2.05 KB, patch)
2013-04-19 12:20 UTC, Kyle M Hall
Details | Diff | Splinter Review
[PASSED QA] Bug 10073: Show ccode or location also if not bound to Authorized Values in XSLT (2.43 KB, patch)
2013-04-23 05:28 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Marcel de Rooy 2013-04-18 08:05:00 UTC
If you do not have ccode or location governed by authorized value (you can release this default connection in the marc structure), these item values are not passed through in the items section, created by buildKohaItemsNamespace for XSLTParse4Display.

This simple patch checks if the authorized value hash on ccode or location returns something and passes the original value in otherwise.

Tested in connection with bug 9995, but can be seen separately.
Comment 1 Marcel de Rooy 2013-04-18 08:12:30 UTC Comment hidden (obsolete)
Comment 2 Kyle M Hall 2013-04-19 12:20:32 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2013-04-23 05:28:00 UTC
Created attachment 17603 [details] [review]
[PASSED QA] Bug 10073: Show ccode or location also if not bound to Authorized Values in XSLT

If you do not have ccode or location governed by authorized value
(you can release this default connection in the marc structure),
these item values are not passed through in the items section,
created by buildKohaItemsNamespace for XSLTParse4Display.

This simple patch checks if the authorized value hash on ccode or
location returns something and passes the original value in otherwise.

Test plan:
Temporarily disconnect ccode and location from authorized values
in MARC structure.
Edit an item, put some values in location and ccode.
Look at this record via opac search (XSLT enabled). Toggle the value of
OPACItemLocation to show ccode or location before call number.
Restore authorized values-connection when applicable.

Note: Since bug 9995 adjusts OPAC XSLT Results, it may be helpful
to apply these
patches when testing this.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
This works as described for the XSLT result list.
The text is shown when OpacItemLocation is set to show collection
or location.

Note: Displaying location and collection without using authorised
values doesn't work in other places like the detail page item table.
So this will need more work to be fully functional.
Comment 4 Jared Camins-Esakov 2013-04-26 22:31:29 UTC
This patch has been pushed to master and 3.12.x.