Bug 10075 - Extend CGI to provide a param_utf8_decode method
Summary: Extend CGI to provide a param_utf8_decode method
Status: RESOLVED DUPLICATE of bug 11944
Alias: None
Product: Koha
Classification: Unclassified
Component: Architecture, internals, and plumbing (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Galen Charlton
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-18 16:30 UTC by Tomás Cohen Arazi
Modified: 2015-05-19 15:17 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 10075 - Extend CGI and overload the param method to one that decodes utf8 by default (3.19 KB, patch)
2013-04-24 17:30 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Tomás Cohen Arazi 2013-04-18 16:30:26 UTC
The key idea is to provide a way to avoid writing decode/encode stuff every time we read a param from CGI.
Comment 1 Tomás Cohen Arazi 2013-04-24 17:30:59 UTC
Created attachment 17658 [details] [review]
Bug 10075 - Extend CGI and overload the param method to one that decodes  utf8 by default

The key idea is to provide a way to avoid writing decode stuff every time we read a param from CGI.

Adds a method for explicitly not decoding input (for images, iso data, etc).

Regards
To+

Sponsored-by: Universidad Nacional de Córdoba
Comment 2 Marcel de Rooy 2013-04-25 10:35:09 UTC
I do not oppose to this idea, but have some questions:
Why not use -utf8 on CGI?
Should you really add a no_decode parameter? It is a rather complicated way of using CGI without this wrapper.
Comment 3 Ketan Kulkarni 2013-09-27 02:34:01 UTC
I am working on a related bug - 6554. utf decoding needs to be done in a few places. Would be great if people submit more ideas/preferences here.

Ketan

(In reply to M. de Rooy from comment #2)
> I do not oppose to this idea, but have some questions:
> Why not use -utf8 on CGI?
> Should you really add a no_decode parameter? It is a rather complicated way
> of using CGI without this wrapper.
Comment 4 Jonathan Druart 2015-01-13 12:28:09 UTC
With 11944, this will certainly become invalid.
Comment 5 Tomás Cohen Arazi 2015-05-19 15:17:57 UTC
This is not needed, as we patched all cgi files to have 'use CGI qw (-utf8)' instead.

*** This bug has been marked as a duplicate of bug 11944 ***