When applying a translation, the In transit string in the item status is not translated.
(In reply to comment #0) > When applying a translation, the In transit string in the item status is not > translated. Forgot to mentionned this problam is in the staff interface.
Created attachment 17561 [details] [review] Patch
Big merge conflict, could you try rebasing it on latest master please Eric
Created attachment 17732 [details] [review] Bug 10083 - In Transit string doesn't get translated in the staff interface For some reason this text inside a <td> isn't getting picked up by the translator unless it's inside a <span>. This patch adds the span and tidies up the text. To test, apply the patch and "translate update" a translation. Searching the po file for "In transit from" should return a result from detail.pl.
Created attachment 17760 [details] [review] Bug 10083 - In Transit string doesn't get translated in the staff interface For some reason this text inside a <td> isn't getting picked up by the translator unless it's inside a <span>. This patch adds the span and tidies up the text. To test, apply the patch and "translate update" a translation. Searching the po file for "In transit from" should return a result from detail.pl. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Created attachment 17767 [details] [review] [PASSED QA] Bug 10083 - In Transit string doesn't get translated in the staff interface For some reason this text inside a <td> isn't getting picked up by the translator unless it's inside a <span>. This patch adds the span and tidies up the text. To test, apply the patch and "translate update" a translation. Searching the po file for "In transit from" should return a result from detail.pl. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Template only change fixing a translation problem.
This patch has been pushed to master and 3.12.x.
Doesn't apply to 3.10.x please resubmit if needed
Created attachment 18169 [details] [review] Bug 10083 [3.10.x] In Transit string doesn't get translated in the staff interface For some reason this text inside a <td> isn't getting picked up by the translator unless it's inside a <span>. This patch adds the span and tidies up the text. To test, apply the patch and "translate update" a translation. Searching the po file for "In transit from" should return a result from detail.pl.
Created attachment 18457 [details] [review] [SIGNED OFF] Bug 10083 [3.10.x] In Transit string doesn't get translated in the staff interface For some reason this text inside a <td> isn't getting picked up by the translator unless it's inside a <span>. This patch adds the span and tidies up the text. To test, apply the patch and "translate update" a translation. Searching the po file for "In transit from" should return a result from detail.pl. Signed-off-by: Gaetan Boisson <gaetan.boisson@biblibre.com>
On a 3.10 instance, before applying the patch, the string "In transit from" is found only once in the French po file (for request.pl). After applying the patch and running updating the French po file, the string is found twice, once for request.pl and once for detail.pl. Signed off.
QA comment: I confirm the proposed patch works for 3.10 branch. Marked as Passed QA.
Created attachment 18459 [details] [review] Bug 10083 [3.10.x] In Transit string doesn't get translated in the staff interface For some reason this text inside a <td> isn't getting picked up by the translator unless it's inside a <span>. This patch adds the span and tidies up the text. To test, apply the patch and "translate update" a translation. Searching the po file for "In transit from" should return a result from detail.pl. Signed-off-by: Gaetan Boisson <gaetan.boisson@biblibre.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Another one for you Bernardo :)
Thanks Owen! Pushed to 3.10.x, will be on 3.10.7
Pushed to 3.8.x, will be in 3.8.14 Thanks :)