Bug 10086 - No way to go back to the basket on uncertain prices page
Summary: No way to go back to the basket on uncertain prices page
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement with 10 votes (vote)
Assignee: Aleisha Amohia
QA Contact: Katrin Fischer
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-21 10:18 UTC by Mathieu Saby
Modified: 2023-06-08 22:26 UTC (History)
8 users (show)

See Also:
Change sponsored?: Sponsored
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This updates the display of the uncertain prices page (Acquisitions > Uncertain prices): 1. The basket name is now linked to the basket in the list of orders with uncertain prices, making it easier to quickly view the basket. 2. The edit link is now formatted as a button and moved into a column (similar to other areas), instead of being a text link in the order column.
Version(s) released in:
22.11.00


Attachments
Bug 10086: Link to go to basket from uncertain prices page (3.54 KB, patch)
2017-02-13 22:57 UTC, Aleisha Amohia
Details | Diff | Splinter Review
Bug 10086: No way to go back to the basket on uncertain prices page (4.14 KB, patch)
2022-06-24 04:30 UTC, Michal Urban
Details | Diff | Splinter Review
Bug 10086: Link to go to basket from uncertain prices page (3.31 KB, patch)
2022-06-24 14:45 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 10086: No way to go back to the basket on uncertain prices page (3.06 KB, patch)
2022-06-24 14:45 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 10086: Link to go to basket from uncertain prices page (4.04 KB, patch)
2022-07-13 11:23 UTC, Nick Clemens
Details | Diff | Splinter Review
Bug 10086: Link to go to basket from uncertain prices page (4.09 KB, patch)
2022-07-14 19:08 UTC, David Nind
Details | Diff | Splinter Review
Bug 10086: Link to go to basket from uncertain prices page (4.15 KB, patch)
2022-08-08 19:48 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 10086: (QA follow-up) Fix TT filters (1.93 KB, patch)
2022-08-08 19:48 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Mathieu Saby 2013-04-21 10:18:48 UTC
I had a basket with uncertain prices.
I click on "uncertain prices" button, fix the price of my order and validated.
But after this operation, I don't see a link for going back to my basket. It would be usefull.

M. Saby
Comment 1 Aleisha Amohia 2017-02-13 22:53:20 UTC
When I click Edit for an order line with uncertain prices, clicking Save and Cancel both take me back to the basket, and the breadcrumbs at the top of the page have a link back to the basket. So i think this bug is no longer valid.

However, there should be a link from the uncertain prices page to the basket. So (I hope you don't mind Mathieu) I am just going to adapt this bug to that.
Comment 2 Aleisha Amohia 2017-02-13 22:57:15 UTC
Created attachment 60167 [details] [review]
Bug 10086: Link to go to basket from uncertain prices page

This patch moves the Edit button into an Edit column, styled with
bootstrap button and font awesome icon, and adds a link on the basket
name to go to the basket.

To test;
1) Add an item with uncertain prices to a basket
2) Go to the vendor of the basket
3) Click Uncertain prices on the left
4) Notice 'edit' button does not look like a button, and basket name is
not a link
5) Apply patch and refresh page
6) Basket name is now a link. Click to confirm it takes you to the right
page
7) Edit button is now in edit column. Confirm it works as expected
8) Confirm you cannot sort on Edit column and the button does not wrap
on a narrower browser

Sponsored-by: Catalyst IT
Comment 3 Rozenn Davenel 2017-03-20 16:29:19 UTC
It works
Comment 4 Jonathan Druart 2017-03-21 18:56:46 UTC
Aleisha, the button looks misplaced. Usually the action buttons are in the last column of the table, do not you think it is better to stick to this rule?
Comment 5 Jonathan Druart 2017-05-03 15:14:17 UTC
Please answer.
Comment 6 Michal Urban 2022-06-24 04:30:30 UTC
Created attachment 136471 [details] [review]
Bug 10086: No way to go back to the basket on uncertain prices page

Fixed the edit button placement to the right-most column and fixed the
the displayed information in the order column from calling non-existent
variables based on the item.

To test:
1) Add an item with uncertain prices to a basket
2) Go to the vendor of the basket
3) Click Uncertain prices on the left
4) Notice 'edit' button does not look like a button, and basket name is
not a link
5) Apply patch and refresh page
6) Basket name is now a link. Click to confirm it takes you to the right
page
7) Edit button is now in edit column. Confirm it works as expected
8) Confirm you cannot sort on Edit column and the button does not wrap
on a narrower browser
9) Check that the correct information is displayed for the order column
(title, author, publisher code, publication year, copyright date, isbn)
Comment 7 Owen Leonard 2022-06-24 13:50:26 UTC
The second patch doesn't apply for me on its own.
Comment 8 Nick Clemens 2022-06-24 14:45:18 UTC
Created attachment 136505 [details] [review]
Bug 10086: Link to go to basket from uncertain prices page

This patch moves the Edit button into an Edit column, styled with
bootstrap button and font awesome icon, and adds a link on the basket
name to go to the basket.

To test;
1) Add an item with uncertain prices to a basket
2) Go to the vendor of the basket
3) Click Uncertain prices on the left
4) Notice 'edit' button does not look like a button, and basket name is
not a link
5) Apply patch and refresh page
6) Basket name is now a link. Click to confirm it takes you to the right
page
7) Edit button is now in edit column. Confirm it works as expected
8) Confirm you cannot sort on Edit column and the button does not wrap
on a narrower browser

Sponsored-by: Catalyst IT
Comment 9 Nick Clemens 2022-06-24 14:45:23 UTC
Created attachment 136506 [details] [review]
Bug 10086: No way to go back to the basket on uncertain prices page

Fixed the edit button placement to the right-most column and fixed the
the displayed information in the order column from calling non-existent
variables based on the item.

To test:
1) Add an item with uncertain prices to a basket
2) Go to the vendor of the basket
3) Click Uncertain prices on the left
4) Notice 'edit' button does not look like a button, and basket name is
not a link
5) Apply patch and refresh page
6) Basket name is now a link. Click to confirm it takes you to the right
page
7) Edit button is now in edit column. Confirm it works as expected
8) Confirm you cannot sort on Edit column and the button does not wrap
on a narrower browser
9) Check that the correct information is displayed for the order column
(title, author, publisher code, publication year, copyright date, isbn)
Comment 10 Owen Leonard 2022-06-24 16:34:09 UTC
The DataTable configuration should have been updated in the second patch, because the wrong columns have disabled sorting. 

Better than numeric column targeting is targeting by table header cell class. See other templates for " { 'bSortable': false, "bSearchable": false, 'aTargets': [ 'NoSort' ] },"
Comment 11 Nick Clemens 2022-07-13 11:23:48 UTC
Created attachment 137681 [details] [review]
Bug 10086: Link to go to basket from uncertain prices page

This patch moves the Edit button into an Edit column, styled with
bootstrap button and font awesome icon, and adds a link on the basket
name to go to the basket.

To test:
1) Add an item with uncertain prices to a basket
2) Go to the vendor of the basket
3) Click Uncertain prices on the left
4) Notice 'edit' button does not look like a button, and basket name is
not a link
5) Apply patch and refresh page
6) Basket name is now a link. Click to confirm it takes you to the right
page
7) Edit button is now in edit column. Confirm it works as expected
8) Confirm you cannot sort on Edit column and the button does not wrap
on a narrower browser
9) Check that the correct information is displayed for the order column
(title, author, publisher code, publication year, copyright date, isbn)

Sponsored-by: Catalyst IT
Comment 12 David Nind 2022-07-14 19:08:34 UTC
Created attachment 137737 [details] [review]
Bug 10086: Link to go to basket from uncertain prices page

This patch moves the Edit button into an Edit column, styled with
bootstrap button and font awesome icon, and adds a link on the basket
name to go to the basket.

To test:
1) Add an item with uncertain prices to a basket
2) Go to the vendor of the basket
3) Click Uncertain prices on the left
4) Notice 'edit' button does not look like a button, and basket name is
not a link
5) Apply patch and refresh page
6) Basket name is now a link. Click to confirm it takes you to the right
page
7) Edit button is now in edit column. Confirm it works as expected
8) Confirm you cannot sort on Edit column and the button does not wrap
on a narrower browser
9) Check that the correct information is displayed for the order column
(title, author, publisher code, publication year, copyright date, isbn)

Sponsored-by: Catalyst IT

Signed-off-by: David Nind <david@davidnind.com>
Comment 13 Katrin Fischer 2022-08-08 19:48:13 UTC
Created attachment 138854 [details] [review]
Bug 10086: Link to go to basket from uncertain prices page

This patch moves the Edit button into an Edit column, styled with
bootstrap button and font awesome icon, and adds a link on the basket
name to go to the basket.

To test:
1) Add an item with uncertain prices to a basket
2) Go to the vendor of the basket
3) Click Uncertain prices on the left
4) Notice 'edit' button does not look like a button, and basket name is
not a link
5) Apply patch and refresh page
6) Basket name is now a link. Click to confirm it takes you to the right
page
7) Edit button is now in edit column. Confirm it works as expected
8) Confirm you cannot sort on Edit column and the button does not wrap
on a narrower browser
9) Check that the correct information is displayed for the order column
(title, author, publisher code, publication year, copyright date, isbn)

Sponsored-by: Catalyst IT

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 14 Katrin Fischer 2022-08-08 19:48:18 UTC
Created attachment 138855 [details] [review]
Bug 10086: (QA follow-up) Fix TT filters

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 15 Tomás Cohen Arazi 2022-08-09 12:02:56 UTC
Pushed to master for 22.11.

Nice work everyone, thanks!
Comment 16 Lucas Gass 2022-09-30 22:39:47 UTC
Enhancement will not be backported to 22.05.x series