Bug 10090 - the ordered and spent page display the itemtype code
Summary: the ordered and spent page display the itemtype code
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: master
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Jonathan Druart
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-22 07:50 UTC by Jonathan Druart
Modified: 2015-06-04 23:30 UTC (History)
8 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 10090: Add itemtype description instead of code (5.06 KB, patch)
2013-04-22 07:54 UTC, Jonathan Druart
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 10090: Add itemtype description instead of code (4.99 KB, patch)
2013-06-03 05:32 UTC, Srdjan Jankovic
Details | Diff | Splinter Review
Bug 10090: Add itemtype description instead of code (3.22 KB, patch)
2013-06-17 10:25 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 10090: Add itemtype description instead of code (3.26 KB, patch)
2014-03-10 14:55 UTC, Biblibre Sandboxes
Details | Diff | Splinter Review
Bug 10090: Add itemtype description instead of code (2.79 KB, patch)
2014-03-13 14:12 UTC, Jonathan Druart
Details | Diff | Splinter Review
[PASSED QA] Bug 10090: Add itemtype description instead of code (3.07 KB, patch)
2014-03-13 14:55 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2013-04-22 07:50:46 UTC
On ordered.pl and spent.pl, the itemtype codes are displayed, instead of descriptions.
Comment 1 Jonathan Druart 2013-04-22 07:54:20 UTC Comment hidden (obsolete)
Comment 2 Srdjan Jankovic 2013-06-03 05:32:35 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2013-06-16 19:57:56 UTC
Hi Jonathan, I just checked master to find out which plugins we now got and there already is an ItemTypes plugin (and 2 plugins for authorised values?) Could you take a look?
Comment 4 Jonathan Druart 2013-06-17 10:25:15 UTC Comment hidden (obsolete)
Comment 5 Jonathan Druart 2013-06-17 10:25:47 UTC
The last patch deals with the existing plugin.
Comment 6 Mathieu Saby 2013-10-01 13:31:08 UTC
Hi
What do you mean by itemtypes, the items types defined at item level (useless for my library), or at biblio level?

Mathieu
Comment 7 Jonathan Druart 2013-10-02 07:21:50 UTC
(In reply to mathieu saby from comment #6)
> Hi
> What do you mean by itemtypes, the items types defined at item level
> (useless for my library), or at biblio level?

It is hardcoded, it is items.itype.
Comment 8 Mathieu Saby 2013-10-02 07:42:00 UTC
Well, I will take a look, but adding biblioitems.itemtype some day could be nice too (by the way, the name of this field is sometime confusing...)

Mathieu
Comment 9 I'm just a bot 2013-10-28 06:15:19 UTC
Patch applied cleanly, go forth and signoff
Comment 10 Biblibre Sandboxes 2014-03-10 14:55:08 UTC
Patch tested with a sandbox, by Broust <jean-manuel.broust@gmail.com>
Comment 11 Biblibre Sandboxes 2014-03-10 14:55:27 UTC Comment hidden (obsolete)
Comment 12 Katrin Fischer 2014-03-11 09:37:15 UTC
The description displays nicely, but I think changing the links is not quite right. I will try to explain:

Ordered: on the 'Ordered' page the link now goes directly to the receive page, but it's missing the invoiceid and the biblionumber, so the display is not quite right and receiving it like this would cause problems because of the missing invoice.

Spent: Removing the link seems ok to me, because of the reason given above. One thing we could do would be link to the invoice it was received in. 

Maybe just change the descriptions with this bug, and leave improving the links to a separate one?
Comment 13 Jonathan Druart 2014-03-13 14:12:24 UTC Comment hidden (obsolete)
Comment 14 Katrin Fischer 2014-03-13 14:55:36 UTC
Created attachment 26304 [details] [review]
[PASSED QA] Bug 10090: Add itemtype description instead of code

On ordered.pl and spent.pl, the itemtype codes are displayed, instead of
descriptions.

Links for the ordernumber should be changed. In ordered.pl, we are
redirected to the receive page. In spent.pl, the links are deleted.

Signed-off-by: Broust <jean-manuel.broust@gmail.com>

Revisited patch: The link to orderreceive was broken, so I undo the
changes.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works alright, itemtype descriptions are shown.
The removed link was potentially 'dangerous' as you shouldn't
get to the receive page for an order, without providing an invoicenumber
first.
Passes all tests and QA script.
Comment 15 Galen Charlton 2014-04-18 22:06:28 UTC
Pushed to master.  Thanks, Jonathan!
Comment 16 Fridolin Somers 2014-08-06 12:02:43 UTC
Pushed to 3.14.x, will be in 3.14.10
Comment 17 Kyle M Hall 2014-08-13 15:30:27 UTC
Picked for 3.12.15!