Bug 10115 - Hiding advanced search in Orders search tab removes plus button
Summary: Hiding advanced search in Orders search tab removes plus button
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Owen Leonard
QA Contact: Jonathan Druart
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-25 11:23 UTC by Jared Camins-Esakov
Modified: 2014-05-26 21:04 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 10115 - Hiding advanced search in Orders search tab removes plus button (2.46 KB, patch)
2013-04-25 12:55 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 10115 - Hiding advanced search in Orders search tab removes plus button (2.50 KB, patch)
2013-04-25 19:30 UTC, Mirko Tietgen
Details | Diff | Splinter Review
Bug 10115 - Hiding advanced search in Orders search tab removes plus button (2.51 KB, patch)
2013-04-26 08:12 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jared Camins-Esakov 2013-04-25 11:23:54 UTC
If you click the plus button to display advanced search options in the Orders search tab on the masthead then hide those options by clicking the minus button, rather than the options being hidden and the plus sign reappearing, but the options and the plus sign vanish.
Comment 1 Owen Leonard 2013-04-25 12:55:04 UTC Comment hidden (obsolete)
Comment 2 Mirko Tietgen 2013-04-25 19:30:59 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2013-04-26 08:12:10 UTC
QA comment:
Simple patch, works as expected.
Marked as Passed QA.
Comment 4 Jonathan Druart 2013-04-26 08:12:22 UTC
Created attachment 17695 [details] [review]
Bug 10115 - Hiding advanced search in Orders search tab removes plus button

The logic of the JavaScript for showing and hiding additional options in
the orders search form wasn't quite right, resulting in the +/- control
being hidden incorrectly.

This patch corrects and simplifies the JS in order to fix the problem.

To test:
 - Open any page in Acquisitions which shows the orders search
   form in the header search bar (for instance, Acquisitions home).
 - Open the orders search tab and click on the "+" to show more
   options.
 - Click the "-" to hide the additional options. The additional options
   should now be hidden and the "+" displayed.

Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>
Works as expected
Comment 5 Jared Camins-Esakov 2013-04-26 11:54:31 UTC
This patch has been pushed to master and 3.12.x.