If you click the plus button to display advanced search options in the Orders search tab on the masthead then hide those options by clicking the minus button, rather than the options being hidden and the plus sign reappearing, but the options and the plus sign vanish.
Created attachment 17684 [details] [review] Bug 10115 - Hiding advanced search in Orders search tab removes plus button The logic of the JavaScript for showing and hiding additional options in the orders search form wasn't quite right, resulting in the +/- control being hidden incorrectly. This patch corrects and simplifies the JS in order to fix the problem. To test: - Open any page in Acquisitions which shows the orders search form in the header search bar (for instance, Acquisitions home). - Open the orders search tab and click on the "+" to show more options. - Click the "-" to hide the additional options. The additional options should now be hidden and the "+" displayed.
Created attachment 17687 [details] [review] Bug 10115 - Hiding advanced search in Orders search tab removes plus button The logic of the JavaScript for showing and hiding additional options in the orders search form wasn't quite right, resulting in the +/- control being hidden incorrectly. This patch corrects and simplifies the JS in order to fix the problem. To test: - Open any page in Acquisitions which shows the orders search form in the header search bar (for instance, Acquisitions home). - Open the orders search tab and click on the "+" to show more options. - Click the "-" to hide the additional options. The additional options should now be hidden and the "+" displayed. Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Works as expected
QA comment: Simple patch, works as expected. Marked as Passed QA.
Created attachment 17695 [details] [review] Bug 10115 - Hiding advanced search in Orders search tab removes plus button The logic of the JavaScript for showing and hiding additional options in the orders search form wasn't quite right, resulting in the +/- control being hidden incorrectly. This patch corrects and simplifies the JS in order to fix the problem. To test: - Open any page in Acquisitions which shows the orders search form in the header search bar (for instance, Acquisitions home). - Open the orders search tab and click on the "+" to show more options. - Click the "-" to hide the additional options. The additional options should now be hidden and the "+" displayed. Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Works as expected
This patch has been pushed to master and 3.12.x.