There is a major change in how fines work in that they are recalculated on return of the item. That should at least be reflected in the syspref finesmode, nicer would be a separate switch. finesmode currently reads: [Calculate and charge] fines (when misc/cronjobs/fines.pl is being run).
On further discussing this on IRC, we got some votes on recalculation being optional. finesmode could still have a note mentioning that not only the fines.pl cronjob can accrue fines.
Created attachment 39967 [details] [review] Bug 10119: Add note about CalculateFinesOnReturn to description of finesmode This adds a note to the descrpition of the finesmode system preference mentioning that CalculateFinesOnReturn is another option for charging fines: Note: Fines can also be charged by the CalculateFinesOnReturn system preference. To test: - Search for the finesmode system preference - Verify the new text shows and is correct
Created attachment 40116 [details] [review] Bug 10119: Add note about CalculateFinesOnReturn to description of finesmode This adds a note to the descrpition of the finesmode system preference mentioning that CalculateFinesOnReturn is another option for charging fines: Note: Fines can also be charged by the CalculateFinesOnReturn system preference. To test: - Search for the finesmode system preference - Verify the new text shows and is correct NOTE: New text appears as expected. You can also just scroll for it on the Circulation preferences tab. Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Created attachment 40163 [details] [review] Bug 10119: Add note about CalculateFinesOnReturn to description of finesmode This adds a note to the descrpition of the finesmode system preference mentioning that CalculateFinesOnReturn is another option for charging fines: Note: Fines can also be charged by the CalculateFinesOnReturn system preference. To test: - Search for the finesmode system preference - Verify the new text shows and is correct NOTE: New text appears as expected. You can also just scroll for it on the Circulation preferences tab. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org>
Patch pushed to master. Thanks Katrin!
Pushed to 3.20.x will be in 3.20.2
Pushed to 3.18.x will be in 3.18.09
Contains string changes, holding till 3.16.14