In opac-results.tt : <img src="[% themelang %]/../images/Star[% SEARCH_RESULT.score_int %].gif" ... But thoses images have been removed to use sprites, see Bug 7500.
Created attachment 19381 [details] [review] Bug 10125 - Babeltheque star image must use sprite When I removed images from the OPAC in favor of sprites I didn't take into account the display of star ratings from Babeltheque. This patch copies the star ratings display from Koha's own ratings display, though it is not dependent on JavaScript. I'm sure testing would be easy for someone with access to the Babeltheque service, but I do not. I temporarily modified the template to set some variables for testing purposes: [% SET SEARCH_RESULT.score_int = 3 %] [% SET SEARCH_RESULT.score_avg = 3 % [% SET SEARCH_RESULT.num_scores = 87 %] This enabled the display of the ratings, allowing me to confirm that stars display correctly. Ratings should work with and without OpacStarRatings enabled.
Created attachment 19451 [details] [review] Bug 10125 - Babeltheque star image must use sprite When I removed images from the OPAC in favor of sprites I didn't take into account the display of star ratings from Babeltheque. This patch copies the star ratings display from Koha's own ratings display, though it is not dependent on JavaScript. I'm sure testing would be easy for someone with access to the Babeltheque service, but I do not. I temporarily modified the template to set some variables for testing purposes: [% SET SEARCH_RESULT.score_int = 3 %] [% SET SEARCH_RESULT.score_avg = 3 % [% SET SEARCH_RESULT.num_scores = 87 %] This enabled the display of the ratings, allowing me to confirm that stars display correctly. Ratings should work with and without OpacStarRatings enabled. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> I also fudged the template to test, so QA would need to be done with someone with Babeltheque access
Hi Jonathan, could you take a look at this please? I hope that you are able to test with a Babeltheque account maybe.
QA Comment: This patch supposes that the Babeltheque ratings depends on OpacStarRatings. It is false. I will provide a followup.
Created attachment 19467 [details] [review] Bug 10125 - Babeltheque star image must use sprite When I removed images from the OPAC in favor of sprites I didn't take into account the display of star ratings from Babeltheque. This patch copies the star ratings display from Koha's own ratings display, though it is not dependent on JavaScript. I'm sure testing would be easy for someone with access to the Babeltheque service, but I do not. I temporarily modified the template to set some variables for testing purposes: [% SET SEARCH_RESULT.score_int = 3 %] [% SET SEARCH_RESULT.score_avg = 3 % [% SET SEARCH_RESULT.num_scores = 87 %] This enabled the display of the ratings, allowing me to confirm that stars display correctly. Ratings should work with and without OpacStarRatings enabled. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> I also fudged the template to test, so QA would need to be done with someone with Babeltheque access Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Created attachment 19468 [details] [review] Bug 10125: Babeltheque does not depend on OpacStarRatings. We have to load star ratings js and css file if Babeltheque is enabled and OpacStarRatings is disabled. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
These patchs can be test on http://catalogue.master33-dev.biblibre.com/cgi-bin/koha/opac-search.pl?q=lila Babeltheque is on and OpacStarRatings is off. Marked as Passed QA.
Pushed to master. Thanks Owen and Jonathan!