At the end of printoverdues.sh, an archive is generated containing all files present in directory given as parameter. As archives are generated in this given directory, they contain previously generated tar files, creating oversized files. Only .pdf files should be archived
Created attachment 17699 [details] [review] Bug 10127 : Printoverdues.sh should tar only pdf files
Test plan : * you must have a directory with some *.html files inside (ideally some files generated by overdue_notices.pl with -html parameter or by gather_print_notices.pl) Without the patch : * run several times (not the same day): misc/cronjobs/printoverdues.sh <directory_path> * look into the last generated tar file with tar tvf <my file>.tar.gz => you can see that the file contains *.tar.gz files With the patch : * proceed as described above => you can see that the file only contains *.pdf file (and is smaller)
I am not quite sure if it is an enhancement or a bugfix
I'd say it's a bugfix. Repeatedly archiving other archives sounds like a bug to me.
I agree with Robin - can we get a sign-of on this?
Tried to test. Pre-patch the nested tar.gz file are created. Post-patch no tar.gz files of any kind are created. Any ideas?
Created attachment 19130 [details] [review] Bug 10127 : Printoverdues.sh should tar only pdf files tar command was missing -P option to allow absolute paths
Created attachment 19287 [details] [review] Bug 10127 : Printoverdues.sh should tar only pdf files Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Created attachment 19624 [details] [review] [PASSED QA] Bug 10127 : Printoverdues.sh should tar only pdf files Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> From the bug report: At the end of printoverdues.sh, an archive is generated containing all files present in directory given as parameter. As archives are generated in this given directory, they contain previously generated tar files, creating oversized files. Only .pdf files should be archived All tests and QA script pass. Worked ok in my tests, only packign PDF in the given directory.
Pushed to master. Thanks, Sophie!
This patch has been pushed to 3.12.x, will be in 3.12.4. Thanks Sophie!
Pushed to 3.10.x, will be in 3.10.10
Pushed to 3.8.x, will be in 3.8.17