Bug 10138 - Add some authorized values in french installer
Summary: Add some authorized values in french installer
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Installation and upgrade (web-based installer) (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Mathieu Saby
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-28 17:38 UTC by Mathieu Saby
Modified: 2015-06-04 23:30 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
PATCH] Bug 10138: Add some authorized values in french installer ; small fixes in frameworks (68.28 KB, patch)
2013-04-28 17:41 UTC, Mathieu Saby
Details | Diff | Splinter Review
Bug 10138: Add some authorized values in french installer ; small fixes in frameworks (68.44 KB, patch)
2013-12-24 09:03 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 10138: FIX sql errors (2.01 KB, patch)
2013-12-24 09:03 UTC, Jonathan Druart
Details | Diff | Splinter Review
[PASSED QA] Bug 10138: Add some authorized values in french installer ; small fixes in frameworks (68.52 KB, patch)
2013-12-27 06:57 UTC, Katrin Fischer
Details | Diff | Splinter Review
[PASSED QA] Bug 10138: FIX sql errors (3.10 KB, patch)
2013-12-27 06:57 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Mathieu Saby 2013-04-28 17:38:37 UTC
The english installer creates and populates some categories in authorized values table (SUGGEST, OPAC_SUG, REPORT_GROUP, LOST, DAMAGED) that are not created by french installer.

M. Saby
Comment 1 Mathieu Saby 2013-04-28 17:41:41 UTC Comment hidden (obsolete)
Comment 2 I'm just a bot 2013-10-24 19:26:50 UTC
Patch applied cleanly, go forth and signoff
Comment 3 Chris Cormack 2013-12-23 20:06:44 UTC
Could someone who speaks french please look at this?
Comment 4 Mathieu Saby 2013-12-23 20:13:48 UTC
I send a message to french list ;-)

Mathieu
Comment 5 Jonathan Druart 2013-12-24 09:03:00 UTC Comment hidden (obsolete)
Comment 6 Jonathan Druart 2013-12-24 09:03:31 UTC Comment hidden (obsolete)
Comment 7 Mathieu Saby 2013-12-24 14:18:05 UTC
Thank you Jonathan.
I see a typo to fix in the main patch:

"INSERT INTO `authorised_values` ( `category`, `authorised_value`, `lib`) VALUES ('DAMAGED','1','Endommagdé');"

Endommadgé-> Endommagé

I will make a followup for this line

Mathieu
Comment 8 Katrin Fischer 2013-12-27 06:57:01 UTC
Created attachment 23827 [details] [review]
[PASSED QA] Bug 10138: Add some authorized values in french installer ; small fixes in frameworks

This patch adds some categories of values in french installer :
- SUGGEST
- OPAC_SUG
- REPORT_GROUP
- LOST
- DAMAGED

SUGGEST and OPAC_SUG are used by Suggestions module.
REPORT_GROUP is used by Reports module.

It also adds a new status for "ETAT" (en commande)

It creates a 995$2 subfield in french frameworks when it did not exist.
It links existing 995$2 subfield with LOST category.

It cleans up the list of authorised values installed with "Lecture publique" framework :
- some codes are moved in general 1-Obligatoire/authorised_values.sql (SUGGEST, REPORT_GROUP)
- some are suppressed, because they are also defined in 1-Obligatoire/authorised_values.sql (langue, COUNTRY, statut)
- the code for interting the left ones is changed (I suppress the `id` column)

To test :
1. Take a fresh new Koha
2. Install Koha choosing French installer and UNIMARC Lecture publique
3. Check the authorised values are imported
4. Check the cataloguing frameworks are usable :
especially 995 $2 field, which must be mapped with LOST values : Perdu, Long retard, Perdu et remboursé, Introuvable
you can also check 101$a (language codes), 102$a (country codes)
5. In OPAC, make a suggestion. See if you can select a cause for your suggestion ("Bestseller" or "'L'exemplaire en rayon est endommagé")
6. In staff interface, manage some suggestions. See if you can select a cause for rejection or acceptation ("Bestseller", "Budget insuffisant" etc)
7. In reports, see if you can sort reports according to values of REPORT_GROUP ("Circulation", "Catalogue", "Adhérents" etc)

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Comments on second patch.
Comment 9 Katrin Fischer 2013-12-27 06:57:33 UTC
Created attachment 23828 [details] [review]
[PASSED QA] Bug 10138: FIX sql errors

There were 2 INSERT in error.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
I have gone ahead and fixed the typo pointed out by Mathieu:
Endommadgé-> Endommagé

Sample files install without problems, tests look good.
Comment 10 Galen Charlton 2013-12-27 14:49:38 UTC
Pushed to master.  Thanks, Mathieu!
Comment 11 Fridolin Somers 2014-08-13 07:28:37 UTC
Pushed to 3.14.x, will be in 3.14.10
Comment 12 Kyle M Hall (khall) 2014-08-13 18:20:28 UTC
Picked for 3.12.15!