The english installer creates and populates some categories in authorized values table (SUGGEST, OPAC_SUG, REPORT_GROUP, LOST, DAMAGED) that are not created by french installer. M. Saby
Created attachment 17773 [details] [review] PATCH] Bug 10138: Add some authorized values in french installer ; small fixes in frameworks This patch adds some categories of values in french installer : - SUGGEST - OPAC_SUG - REPORT_GROUP - LOST - DAMAGED SUGGEST and OPAC_SUG are used by Suggestions module. REPORT_GROUP is used by Reports module. It also adds a new status for "ETAT" (en commande) It creates a 995$2 subfield in french frameworks when it did not exist. It links existing 995$2 subfield with LOST category. It cleans up the list of authorised values installed with "Lecture publique" framework : - some codes are moved in general 1-Obligatoire/authorised_values.sql (SUGGEST, REPORT_GROUP) - some are suppressed, because they are also defined in 1-Obligatoire/authorised_values.sql (langue, COUNTRY, statut) - the code for interting the left ones is changed (I suppress the `id` column) To test : 1. Take a fresh new Koha 2. Install Koha choosing French installer and UNIMARC Lecture publique 3. Check the authorised values are imported 4. Check the cataloguing frameworks are usable : especially 995 $2 field, which must be mapped with LOST values : Perdu, Long retard, Perdu et remboursé, Introuvable you can also check 101$a (language codes), 102$a (country codes) 5. In OPAC, make a suggestion. See if you can select a cause for your suggestion ("Bestseller" or "'L'exemplaire en rayon est endommagé") 6. In staff interface, manage some suggestions. See if you can select a cause for rejection or acceptation ("Bestseller", "Budget insuffisant" etc) 7. In reports, see if you can sort reports according to values of REPORT_GROUP ("Circulation", "Catalogue", "Adhérents" etc) M. Saby
Patch applied cleanly, go forth and signoff
Could someone who speaks french please look at this?
I send a message to french list ;-) Mathieu
Created attachment 23799 [details] [review] Bug 10138: Add some authorized values in french installer ; small fixes in frameworks
Created attachment 23800 [details] [review] Bug 10138: FIX sql errors
Thank you Jonathan. I see a typo to fix in the main patch: "INSERT INTO `authorised_values` ( `category`, `authorised_value`, `lib`) VALUES ('DAMAGED','1','Endommagdé');" Endommadgé-> Endommagé I will make a followup for this line Mathieu
Created attachment 23827 [details] [review] [PASSED QA] Bug 10138: Add some authorized values in french installer ; small fixes in frameworks This patch adds some categories of values in french installer : - SUGGEST - OPAC_SUG - REPORT_GROUP - LOST - DAMAGED SUGGEST and OPAC_SUG are used by Suggestions module. REPORT_GROUP is used by Reports module. It also adds a new status for "ETAT" (en commande) It creates a 995$2 subfield in french frameworks when it did not exist. It links existing 995$2 subfield with LOST category. It cleans up the list of authorised values installed with "Lecture publique" framework : - some codes are moved in general 1-Obligatoire/authorised_values.sql (SUGGEST, REPORT_GROUP) - some are suppressed, because they are also defined in 1-Obligatoire/authorised_values.sql (langue, COUNTRY, statut) - the code for interting the left ones is changed (I suppress the `id` column) To test : 1. Take a fresh new Koha 2. Install Koha choosing French installer and UNIMARC Lecture publique 3. Check the authorised values are imported 4. Check the cataloguing frameworks are usable : especially 995 $2 field, which must be mapped with LOST values : Perdu, Long retard, Perdu et remboursé, Introuvable you can also check 101$a (language codes), 102$a (country codes) 5. In OPAC, make a suggestion. See if you can select a cause for your suggestion ("Bestseller" or "'L'exemplaire en rayon est endommagé") 6. In staff interface, manage some suggestions. See if you can select a cause for rejection or acceptation ("Bestseller", "Budget insuffisant" etc) 7. In reports, see if you can sort reports according to values of REPORT_GROUP ("Circulation", "Catalogue", "Adhérents" etc) Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Comments on second patch.
Created attachment 23828 [details] [review] [PASSED QA] Bug 10138: FIX sql errors There were 2 INSERT in error. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> I have gone ahead and fixed the typo pointed out by Mathieu: Endommadgé-> Endommagé Sample files install without problems, tests look good.
Pushed to master. Thanks, Mathieu!
Pushed to 3.14.x, will be in 3.14.10
Picked for 3.12.15!