koha-start-zebra should check stuff like if the instance exists, if its enabled, if zebra isn't already running, etc.
Created attachment 17786 [details] [review] Bug 10144 - koha-start-zebra error handling koha-start-zebra now - Checks the instance exists. - Checks the instance is enabled. - Checks if the zebra daemon is already running. Regards To+ Sponsored-by: Universidad Nacional de Córdoba
Created attachment 17809 [details] [review] Bug 10144 - koha-start-zebra error handling koha-start-zebra now - Checks the instance exists. - Checks the instance is enabled. - Checks if the zebra daemon is already running. Regards To+ Sponsored-by: Universidad Nacional de Córdoba
Before the patch, starting with no instance name silently failed,now ./debian/scripts/koha-start-zebra Starts Zebra for Koha instances. Usage: ./debian/scripts/koha-start-zebra instancename1 instancename2... Missing instance name... sudo ./debian/scripts/koha-start-zebra persona Zebra already running for instance persona. sudo koha-disable persona sudo ./debian/scripts/koha-start-zebra persona Instance persona disabled. No action taken. ps axf | grep "zebrasrv" 10168 pts/3 S+ 0:00 | \_ grep zebrasrv sudo ./debian/scripts/koha-start-zebra persona Starting Zebra server for persona ps axf | grep "zebrasrv" 10250 pts/3 S+ 0:00 | \_ grep zebrasrv 10216 ? S 0:00 daemon --name=persona-koha-zebra --errlog=/var/log/koha/persona/zebra-error.log --stdout=/var/log/koha/persona/zebra.log --output=/var/log/koha/persona/zebra-output.log --verbose=1 --respawn --delay=30 --user=persona-koha.persona-koha -- zebrasrv -v none,fatal,warn -f /etc/koha/sites/persona/koha-conf.xml 10217 ? S 0:00 \_ zebrasrv -v none,fatal,warn -f /etc/koha/sites/persona/koha-conf.xml
Created attachment 17829 [details] [review] Signed off patch
Created attachment 17839 [details] [review] Bug 10144 - koha-start-zebra error handling koha-start-zebra now - Checks the instance exists. - Checks the instance is enabled. - Checks if the zebra daemon is already running. Regards To+ Sponsored-by: Universidad Nacional de Córdoba Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Mason James <mtj@kohaaloha.com>
(In reply to comment #5) > Created attachment 17839 [details] [review] [review] > Bug 10144 - koha-start-zebra error handling > > koha-start-zebra now > - Checks the instance exists. > - Checks the instance is enabled. > - Checks if the zebra daemon is already running. > > Regards > To+ > > Sponsored-by: Universidad Nacional de Córdoba > Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> > Signed-off-by: Mason James <mtj@kohaaloha.com> passing QA on this...
This patch has been pushed to master and 3.12.x.
Pushed to 3.10.x will be in 3.10.6
Pushed to 3.8.x, will be in 3.8.14