Bug 10146 - koha-stop-zebra error handling
Summary: koha-stop-zebra error handling
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Packaging (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Tomás Cohen Arazi
QA Contact:
URL:
Keywords:
Depends on:
Blocks: 4876 10259
  Show dependency treegraph
 
Reported: 2013-04-29 14:10 UTC by Tomás Cohen Arazi
Modified: 2014-12-07 20:02 UTC (History)
4 users (show)

See Also:
Change sponsored?: Sponsored
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 10146 - koha-stop-zebra error handling (3.87 KB, patch)
2013-04-29 14:10 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 10146 - koha-stop-zebra error handling (4.03 KB, patch)
2013-04-29 18:10 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 10146 - koha-stop-zebra error handling (4.06 KB, patch)
2013-04-30 13:14 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 10146 - koha-stop-zebra error handling (4.11 KB, patch)
2013-05-12 22:56 UTC, Robin Sheat
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Tomás Cohen Arazi 2013-04-29 14:10:06 UTC
koha-stop-zebra should check stuff like if the instance exists, if its enabled, if zebra isn't already running, etc.
Comment 1 Tomás Cohen Arazi 2013-04-29 14:10:48 UTC Comment hidden (obsolete)
Comment 2 Tomás Cohen Arazi 2013-04-29 18:10:43 UTC Comment hidden (obsolete)
Comment 3 Chris Cormack 2013-04-30 04:06:02 UTC
Everything works fine, except we get a double up on the usage statement now


 ./debian/scripts/koha-stop-zebra                     
Stops Zebra for Koha instances.

Usage: ./debian/scripts/koha-stop-zebra instancename1 instancename2...

Usage: ./debian/scripts/koha-stop-zebra instancename...
Comment 4 Tomás Cohen Arazi 2013-04-30 13:14:48 UTC Comment hidden (obsolete)
Comment 5 Robin Sheat 2013-05-12 22:56:16 UTC
Created attachment 18107 [details] [review]
Bug 10146 - koha-stop-zebra error handling

koha-stop-zebra now
- Checks the instance exists.
- Checks the instance is enabled.
- Checks if the zebra daemon is already running.

Regards
To+

Edit: Corrected the die message

Sponsored-by: Universidad Nacional de Córdoba
Signed-off-by: Robin Sheat <robin@catalyst.net.nz>
Comment 6 Jared Camins-Esakov 2013-05-15 13:38:38 UTC
This patch has been pushed to master and 3.12.x.
Comment 7 Bernardo Gonzalez Kriegel 2013-06-14 02:36:27 UTC
Pushed to 3.10.x, will be in 3.10.7
Comment 8 Chris Hall 2013-06-17 08:00:55 UTC
Pushed to 3.8.x, will be in 3.8.14