Bug 10150 - koha-email-disable error handling
Summary: koha-email-disable error handling
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Packaging (show other bugs)
Version: master
Hardware: All All
: P5 - low normal (vote)
Assignee: Bugs List
QA Contact:
URL:
Keywords:
Depends on:
Blocks: 4876
  Show dependency treegraph
 
Reported: 2013-04-29 15:33 UTC by Tomás Cohen Arazi
Modified: 2013-12-05 20:09 UTC (History)
4 users (show)

See Also:
Change sponsored?: Sponsored
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 10150 - koha-email-disable error handling (3.33 KB, patch)
2013-04-29 15:55 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Signed off patch (3.39 KB, patch)
2013-04-29 23:49 UTC, Chris Cormack
Details | Diff | Splinter Review
Bug 10150 - koha-email-disable error handling (3.47 KB, patch)
2013-05-02 04:09 UTC, Mason James
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Tomás Cohen Arazi 2013-04-29 15:33:01 UTC
koha-email-disable should check stuff like if the instance exists, if the email is already disabled.
Comment 1 Tomás Cohen Arazi 2013-04-29 15:55:18 UTC Comment hidden (obsolete)
Comment 2 Chris Cormack 2013-04-29 23:48:44 UTC
./debian/scripts/koha-email-disable      
Disables the email for Koha instances.

Usage: ./debian/scripts/koha-email-disable instancename1 instancename2...

Missing instance name...

./debian/scripts/koha-email-disable persona
Email already disabled for instance persona.

./debian/scripts/koha-email-disable per
Unknown instance per.

./debian/scripts/koha-email-disable per persona 
Unknown instance per.
Email already disabled for instance persona.
Comment 3 Chris Cormack 2013-04-29 23:49:11 UTC Comment hidden (obsolete)
Comment 4 Mason James 2013-05-02 04:09:41 UTC
Created attachment 17877 [details] [review]
Bug 10150 - koha-email-disable error handling

koha-email-disable now
- Checks the instance exists.
- Checks if email is already disabled.

Regards
To+

Sponsored-by: Universidad Nacional de Córdoba
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Mason James <mtj@kohaaloha.com>
Comment 5 Mason James 2013-05-02 04:10:13 UTC
> Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
> Signed-off-by: Mason James <mtj@kohaaloha.com>

passing QA on this patch...
Comment 6 Galen Charlton 2013-05-02 22:09:38 UTC
Pushed to master.  Thanks, Tomás!
Comment 7 Chris Cormack 2013-05-09 09:27:39 UTC
Pushed to 3.10.x will be in 3.10.6