Bug 10152 - Default sorting wrong in parcels.pl
Summary: Default sorting wrong in parcels.pl
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Bugs List
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-04-29 16:32 UTC by Jared Camins-Esakov
Modified: 2013-12-05 20:09 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 10152: Default sorting wrong in parcels.pl (1.43 KB, patch)
2013-04-29 16:37 UTC, Jared Camins-Esakov
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 10152: Default sorting wrong in parcels.pl (1.53 KB, patch)
2013-04-30 18:06 UTC, Owen Leonard
Details | Diff | Splinter Review
[PASSED QA] Bug 10152: Default sorting wrong in parcels.pl (1.57 KB, patch)
2013-05-01 06:34 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jared Camins-Esakov 2013-04-29 16:32:04 UTC
When you are receiving an order, the list of existing invoices should appear in reverse chronological order. Unfortunately, right now it appears in ID order.
Comment 1 Jared Camins-Esakov 2013-04-29 16:37:28 UTC Comment hidden (obsolete)
Comment 2 Jared Camins-Esakov 2013-04-29 16:42:15 UTC
I have no idea what the "Line" column is supposed to mean, and perhaps we should get rid of it as it appears to have no meaning at all, but this bug is not for that issue. It is merely to correct a typo that means that the default sorting never gets applied.
Comment 3 Owen Leonard 2013-04-30 18:06:45 UTC Comment hidden (obsolete)
Comment 4 Katrin Fischer 2013-05-01 06:34:20 UTC
Created attachment 17864 [details] [review]
[PASSED QA] Bug 10152: Default sorting wrong in parcels.pl

When you are receiving an order, the list of existing invoices should
appear in reverse chronological order. Unfortunately, right now it
appears in regular chronological order.

To test:
1) Make sure you have multiple invoices that have varying shipment
   dates for a vendor. We will assume this vendor is called "Example
   Vendor."
2) Choose the "Receive shipments" button on the Example Vendor page.
3) Note that the invoices are sorted by regular chronological order.
4) Apply patch.
5) Refresh "Receive shipment" page. Note that invoices are now sorted
   in reverse chronological order.
6) Sign off.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works as described.
Comment 5 Jared Camins-Esakov 2013-05-01 10:26:27 UTC
This patch has been pushed to master and 3.12.x.
Comment 6 Chris Cormack 2013-05-08 07:48:37 UTC
Pushed to 3.10.x will be in 3.10.6