Created attachment 17880 [details] non translatable strings The bug 9215 enabled the translation of the "Status" information in the manage-marc-import page. But the same problem remains with other strings in this page. See screenshot.
Created attachment 17900 [details] [review] proposed patch #1 [MT11604] Like in bug 9215, the new strings begin with a capital letter. It's thus possible to check the new behaviour even if you stay in English mode. The five fields showed in the screenshot use now string in templates which can be translated.
Created attachment 17917 [details] [review] Bug 10170: strings in MARC import made translatable Following bug 9215: non translatable strings are now present in the template and translatable Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Not only does this make the strings translatable it makes the template a lot easier to read
Made for Rennes 2. Thank you Adrien & Chris ;-) M. Saby
Created attachment 18020 [details] [review] Bug 10170: strings in MARC import made translatable Following bug 9215: non translatable strings are now present in the template and translatable Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Not only does this make the strings translatable it makes the template a lot easier to read Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
QA Comment: Clear changes to template! Table design still refers to value 'use_template' for overlay_action. This seems to be obsolete? Followup for table needed? record_lis.status: you do not include 'error' ,'staged','items_reverted'? See table design. If needed, please send a followup. record_lis.overlay_status: Same for 'auto_match','manual_match'? It seems that Stage-marc-import does not correctly save my actions. When I choose Ignore, manage-marc-import comes back with Add. If I change the values on manage-marc-import, it looks okay though. So this is outside scope of this report. Can you confirm this error? Although this may still need some attention, we are improving the template. Passed QA
Created attachment 18257 [details] [review] bug 10170: expose more managed staged MARC strings to translation This commit makes it possible to translated the 'staged' and 'error' record statuses as well as the 'auto_match' overlay status. Also takes out a bit of HTML cruft in one string that is not needed for translation. Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Adrien's patch is fine as far as it goes, but I've attached a follow-up that addresses Marcel's observation about the 'auto_match' overlay status and 'staged' and 'error' record status -- for simple stuff like this, I prefer to push a patch or a patch series that completely addresses the problem. I've intentionally not supplied anything for the 'manual_match' and 'items_reverted' statuses, as there's at present no code that will set them. Hopefully this can be fixed in time for 3.14. For the record, the intention was that 'manual_match' would signify that a user had performed a search and manually identified a matching bib record, while 'items_reverted' would signify an operation that would remove items added during a previous commit without reverting the bib record as well.
Created attachment 19496 [details] [review] bug 10170: expose more managed staged MARC strings to translation This commit makes it possible to translated the 'staged' and 'error' record statuses as well as the 'auto_match' overlay status. Also takes out a bit of HTML cruft in one string that is not needed for translation. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Created attachment 19626 [details] [review] [PASSED QA] Bug 10170: strings in MARC import made translatable Following bug 9215: non translatable strings are now present in the template and translatable Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Not only does this make the strings translatable it makes the template a lot easier to read Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> All tests pass.
Created attachment 19627 [details] [review] [PASSED QA] Bug 10170: expose more managed staged MARC strings to translation This commit makes it possible to translated the 'staged' and 'error' record statuses as well as the 'auto_match' overlay status. Also takes out a bit of HTML cruft in one string that is not needed for translation. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> All tests pass. New strings are parsed into the po files: "%s Always add items %s Add items only if matching bib was found %s Add items only if no matching bib was found %s Ignore items %s %s %s %s " "%s No match %s Match applied %s Match found %s %s %s "
Pushed to master. Thanks, Adrien!
This patch has been pushed to 3.12.x, will be in 3.12.3. Thanks Adrien!
Pushed to 3.10.x, will be in 3.10.10