Bug 10171 - Add a header in Advanced Search (staff interface)
Summary: Add a header in Advanced Search (staff interface)
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Aleisha Amohia
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-02 09:03 UTC by Mathieu Saby
Modified: 2016-12-05 21:27 UTC (History)
5 users (show)

See Also:
Change sponsored?: Sponsored
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 10171: Add a search box include on advanced search and item search pages (4.68 KB, patch)
2016-04-27 03:37 UTC, Aleisha Amohia
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 10171: Add a search box include on advanced search and item search pages (4.79 KB, patch)
2016-04-28 01:51 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 10171 [Follow-up] Add a header in Advanced Search (staff interface) (5.56 KB, patch)
2016-04-28 01:52 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 10171: Add a search box include on advanced search and item search pages (4.92 KB, patch)
2016-04-28 07:33 UTC, Marc Véron
Details | Diff | Splinter Review
Bug 10171 [Follow-up] Add a header in Advanced Search (staff interface) (5.65 KB, patch)
2016-04-28 07:34 UTC, Marc Véron
Details | Diff | Splinter Review
[PASSED QA] Bug 10171: Add a search box include on advanced search and item search pages (4.99 KB, patch)
2016-04-28 12:29 UTC, Katrin Fischer
Details | Diff | Splinter Review
[PASSED QA] Bug 10171 [Follow-up] Add a header in Advanced Search (staff interface) (5.71 KB, patch)
2016-04-28 12:29 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 10171: (QA followup) Make search tests use the right form (1.58 KB, patch)
2016-05-02 18:50 UTC, Tomás Cohen Arazi
Details | Diff | Splinter Review
Bug 10171: (QA followup) Make search tests use the right form (1.68 KB, patch)
2016-05-04 11:50 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Mathieu Saby 2013-05-02 09:03:21 UTC
There is no header in Advanced Search page (search.pl)
I don't see why, as it could be interesting to have the ability to make a checkin or checkout from this page.

M. Saby
Comment 1 Mathieu Saby 2013-05-02 09:06:52 UTC
(The design of advanced search page could be improved too : lot of wasted space, need to scroll for accessing the buttons.... But it deserves an other bug)
M. Saby
Comment 2 Aleisha Amohia 2016-04-27 03:37:32 UTC Comment hidden (obsolete)
Comment 3 Aleisha Amohia 2016-04-27 04:47:41 UTC
(In reply to mathieu saby from comment #1)
> (The design of advanced search page could be improved too : lot of wasted
> space, need to scroll for accessing the buttons.... But it deserves an other
> bug)
> M. Saby

I have created Bug 16363 and Bug 16364 for this :)
Comment 4 Owen Leonard 2016-04-28 01:51:53 UTC Comment hidden (obsolete)
Comment 5 Owen Leonard 2016-04-28 01:52:53 UTC Comment hidden (obsolete)
Comment 6 Marc Véron 2016-04-28 07:33:39 UTC Comment hidden (obsolete)
Comment 7 Marc Véron 2016-04-28 07:34:47 UTC Comment hidden (obsolete)
Comment 8 Katrin Fischer 2016-04-28 12:28:50 UTC
I've tested this on top of bug 16363 to see how they work together. No conflicts and works nicely!
Comment 9 Katrin Fischer 2016-04-28 12:29:43 UTC
Created attachment 50906 [details] [review]
[PASSED QA] Bug 10171: Add a search box include on advanced search and item search pages

This patch creates a new file: adv-search.inc. This search include has
no catalog search (as it makes no sense to have the catalog search tab
on the advanced search page).
The item search page uses home-search.inc (with catalog search) as the
catalog search is different to the item search.

To test:
1) Go to Search (advanced search)
2) Confirm search header is there with no catalog search tab and works
   as expected
3) Go to item search
4) Confirm search header is there with catalog search tab and works as
   expected

Sponsored-by: Catalyst IT
Signed-off-by: Owen Leonard <oleonard@myacpl.org>

Tested together with follow up patch, works as expected.
Signed-off-by: Marc Véron <veron@veron.ch>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 10 Katrin Fischer 2016-04-28 12:29:47 UTC
Created attachment 50907 [details] [review]
[PASSED QA] Bug 10171 [Follow-up] Add a header in Advanced Search (staff interface)

This patch re-indents the new include file because it's not often you
get to help a new file come into the world, it should be indented
nicely.

Signed-off-by: Marc Véron <veron@veron.ch>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Comment 11 Kyle M Hall 2016-04-29 11:38:50 UTC
Pushed to master! Should be in the May 2016 release. Arigato Aleisha!
Comment 12 Tomás Cohen Arazi 2016-05-02 18:50:31 UTC Comment hidden (obsolete)
Comment 13 Tomás Cohen Arazi 2016-05-02 18:51:50 UTC
@RM, please push the last followup to adjust tests to the new page layout.
Comment 14 Marcel de Rooy 2016-05-04 11:50:03 UTC
Created attachment 51184 [details] [review]
Bug 10171: (QA followup) Make search tests use the right form

This bug removed the search tab from the main search box, so the tests
that use /cgi-bin/koha/catalogue/search.pl for searching, should use
the advanced search box instead.

To test:
- Run
  $ prove t/db_dependent/www/search_utf8.t
=> FAIL: Several tests related to searching on the intranet interface fail.
- Apply the patch
- Run
  $ prove t/db_dependent/www/search_utf8.t
=> SUCCESS: Tests pass
- Be happy

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 15 Kyle M Hall 2016-05-04 14:22:44 UTC
Followup pushed to master for 16.05, thanks Tomas!