Bug 10178 - Typos in plugins for 006 and 008 in MARC21
Summary: Typos in plugins for 006 and 008 in MARC21
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: 3.14
Hardware: All All
: P5 - low trivial (vote)
Assignee: Bernardo Gonzalez Kriegel
QA Contact:
URL:
Keywords:
: 10242 (view as bug list)
Depends on: 6709
Blocks:
  Show dependency treegraph
 
Reported: 2013-05-02 21:37 UTC by Katrin Fischer
Modified: 2014-12-07 20:03 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: String patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 10178 - Typos in plugins for 006 and 008 in MARC21 (24.35 KB, patch)
2013-05-03 01:34 UTC, Bernardo Gonzalez Kriegel
Details | Diff | Splinter Review
Bug 10178 - Typos in plugins for 006 and 008 in MARC21 (94.53 KB, patch)
2013-05-04 15:37 UTC, Bernardo Gonzalez Kriegel
Details | Diff | Splinter Review
Bug 10178 - Typos in plugins for 006 and 008 in MARC21 (94.61 KB, patch)
2013-05-09 19:49 UTC, Nicole C. Engard
Details | Diff | Splinter Review
[PASSED QA] Bug 10178 - Typos in plugins for 006 and 008 in MARC21 (94.76 KB, patch)
2013-05-12 08:45 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2013-05-02 21:37:19 UTC
While translating I noticed a few typos in the 2 plugins for 006 and 008, I missed to note them, except for this one:

008:
<Value code="i"><description>Inclusive dates of colletion</description></Value>
Comment 1 Katrin Fischer 2013-05-02 22:07:33 UTC
008:
<Value code="r"><description>Instrutional materials</description></Value>
Comment 2 Katrin Fischer 2013-05-02 22:10:42 UTC
008:
<Value code="w"><description>Law reorts and digests</description></Value>
Comment 3 Katrin Fischer 2013-05-02 22:39:56 UTC
<Value code="z"><description>Teatries</description></Value>
Comment 4 Bernardo Gonzalez Kriegel 2013-05-03 01:34:55 UTC Comment hidden (obsolete)
Comment 5 Bernardo Gonzalez Kriegel 2013-05-04 15:37:42 UTC Comment hidden (obsolete)
Comment 6 Nicole C. Engard 2013-05-09 19:49:11 UTC Comment hidden (obsolete)
Comment 7 Katrin Fischer 2013-05-12 08:45:13 UTC
Created attachment 18086 [details] [review]
[PASSED QA] Bug 10178 - Typos in plugins for 006 and 008 in MARC21

Well, not only typos. There is also a NEW update for
006/8 Music on April 2013. And 3 missing values in 006.

Revised descriptions and labels, source LOC page.
Strings spell checked.

To test:
1) Apply the patch
2) Test that MARC21 006 and 008 value builders works
properly.

Small string changes.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
All tests pass

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
XML changes only, passes all tests.
Contains string changes, so should go into 3.14.
Comment 8 Tomás Cohen Arazi 2013-05-14 19:24:32 UTC
*** Bug 10242 has been marked as a duplicate of this bug. ***
Comment 9 Galen Charlton 2013-05-20 15:04:13 UTC
Pushed to master.  Thanks, Bernardo!

The typo fixes aside, because of the April 2013 updates to the 006 for music, this patch should be backported to stable.
Comment 10 Tomás Cohen Arazi 2013-05-21 14:11:28 UTC
Pushed to 3.12.x. This will be in 3.12.1. Thanks!
Note: this probably doesn't need to be applied to 3.10.x and older branches.
Comment 11 Bernardo Gonzalez Kriegel 2013-05-28 01:46:16 UTC
This patch corrects or updates strings that are already in 3.10.6, 
I will apply it.

Pushed to 3.10.x, will be in 3.10.7
Comment 12 Chris Hall 2013-05-29 09:53:04 UTC
A quick look through this patch shows that it seems to be applicable for 3.8.x, however the patch in its current form does not apply cleanly.

It is possible for you to rebase and submit a version for 3.8.x?
Comment 13 Bernardo Gonzalez Kriegel 2013-05-29 11:39:11 UTC
Chris, to apply this you need first Bug 6709 (and one more at least, read the final comments).
Comment 14 Chris Hall 2013-06-06 09:31:32 UTC
Thanks Bernardo

I was able to get this to apply cleanly after applying both patches on 9358, both patches on 6709 and then this patch.

Pushed to 3.8.x and will be in 3.8.14

Thanks again :)