When you delete a record that is used in an order, the basket summary displays: Deleted bibliographic notice, can't find title. While it would be nice if it showed a note about the deletion and the title from the deletedbilbio table, it would be better if it used 'record' instead of notice.
Created attachment 37894 [details] [review] Bug 10181: Acq - Improve message for deleted records There are some issues here: 1/ Message not translatable (set in the pl file) 2/ ' by 'displayed even if no author defined 3/ Message not the same every where 4/ Nothing displayed on the invoice page Test plan: 1/ Create a basket 2/ Add 4 orders A, B, C, D 3/ On the basket, you see "$title by $author", or "$title" if no author defined 4/ Delete order A, B 5/ Close the basket 6/ Receive B, C 7/ Delete record created for A, C 8/ Go on the basket page, you should see the title and "Deleted bibliographic record, can't find title" for the deleted record 9/ Go on the invoice page, you should see the title and "Deleted bibliographic record, can't find title" for the deleted record
Applying: Bug 10181: Acq - Improve message for deleted records fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt). Repository lacks necessary blobs to fall back on 3-way merge.
Created attachment 42070 [details] [review] Bug 10181: Make string translatable
Created attachment 42071 [details] [review] Bug 10181: Acq - Improve message for deleted records There are some issues here: 1/ Message not translatable (set in the pl file) 2/ ' by 'displayed even if no author defined 3/ Message not the same every where 4/ Nothing displayed on the invoice page Test plan: 1/ Create a basket 2/ Add 4 orders A, B, C, D 3/ On the basket, you see "$title by $author", or "$title" if no author defined 4/ Delete order A, B 5/ Close the basket 6/ Receive B, C 7/ Delete record created for A, C 8/ Go on the basket page, you should see the title and "Deleted bibliographic record, can't find title" for the deleted record 9/ Go on the invoice page, you should see the title and "Deleted bibliographic record, can't find title" for the deleted record
(In reply to Marcel de Rooy from comment #2) > Applying: Bug 10181: Acq - Improve message for deleted records > fatal: sha1 information is lacking or useless > (koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt). > Repository lacks necessary blobs to fall back on 3-way merge. Oops, I have forgotten a patch!
Created attachment 42098 [details] [review] Bug 10181: Acq - Improve message for deleted records Test plan didn't quite work for the step 6, but it doesn't have any effect on this patch. So looks good to me. Signed-off-by: Joonas Kylmälä <j.kylmala@gmail.com>
Created attachment 42099 [details] [review] Bug 10181: Make string translatable Signed-off-by: Joonas Kylmälä <j.kylmala@gmail.com>
Created attachment 42721 [details] [review] Bug 10181: Make string translatable Signed-off-by: Joonas Kylmälä <j.kylmala@gmail.com>
Created attachment 42722 [details] [review] Bug 10181: Acq - Improve message for deleted records There are some issues here: 1/ Message not translatable (set in the pl file) 2/ ' by 'displayed even if no author defined 3/ Message not the same every where 4/ Nothing displayed on the invoice page Test plan: 1/ Create a basket 2/ Add 4 orders A, B, C, D 3/ On the basket, you see "$title by $author", or "$title" if no author defined 4/ Delete order A, B 5/ Close the basket 6/ Receive B, C 7/ Delete record created for A, C 8/ Go on the basket page, you should see the title and "Deleted bibliographic record, can't find title" for the deleted record 9/ Go on the invoice page, you should see the title and "Deleted bibliographic record, can't find title" for the deleted record Signed-off-by: Joonas Kylmälä <j.kylmala@gmail.com>
Created attachment 42985 [details] [review] [PASSED QA] Bug 10181: Make string translatable Signed-off-by: Joonas Kylmälä <j.kylmala@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 42986 [details] [review] [PASSED QA] Bug 10181: Acq - Improve message for deleted records There are some issues here: 1/ Message not translatable (set in the pl file) 2/ ' by 'displayed even if no author defined 3/ Message not the same every where 4/ Nothing displayed on the invoice page Test plan: 1/ Create a basket 2/ Add 4 orders A, B, C, D 3/ On the basket, you see "$title by $author", or "$title" if no author defined 4/ Delete order A, B 5/ Close the basket 6/ Receive B, C 7/ Delete record created for A, C 8/ Go on the basket page, you should see the title and "Deleted bibliographic record, can't find title" for the deleted record 9/ Go on the invoice page, you should see the title and "Deleted bibliographic record, can't find title" for the deleted record Signed-off-by: Joonas Kylmälä <j.kylmala@gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Patches pushed to master. Thanks Jonathan!
String changes, held for 3.20.6
Pushed to 3.20.x will be in 3.20.6
Pushed to 3.18.13, and released.