Typo to fix in koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-add.tt replace "2/years" with "2/year" in this block : [% IF ( periodicity9 ) %] <option value="9" selected="selected">2/years</option> [% ELSE %] <option value="9">2/year</option> [% END %] M. Saby
Created attachment 17945 [details] [review] [PATCH] Bug 10186: Fix a typo in subscription-add.tt : 2/years should be 2/year In subscription-add.tt dropdown list for periodiciy, the description for 9 value should be "2/year" (2 issues each year) At present, if the option value is selected, it is "2/years". This patch supresses the "s" after "year". To test : - in a subscription, change periodicity to "2/year" - save the subscription - reopen it and check the value is labelled "2/year" M. Saby
Created attachment 18013 [details] [review] Bug 10186: Fix a typo in subscription-add.tt : 2/years should be 2/year In subscription-add.tt dropdown list for periodiciy, the description for 9 value should be "2/year" (2 issues each year) At present, if the option value is selected, it is "2/years". This patch supresses the "s" after "year". To test : - in a subscription, change periodicity to "2/year" - save the subscription - reopen it and check the value is labelled "2/year" Signed-off-by: David Cook <dcook@prosentient.com.au> Trivial change. Works as described.
Created attachment 18014 [details] [review] Bug 10186: Fix a typo in subscription-add.tt : 2/years should be 2/year In subscription-add.tt dropdown list for periodiciy, the description for 9 value should be "2/year" (2 issues each year) At present, if the option value is selected, it is "2/years". This patch supresses the "s" after "year". To test : - in a subscription, change periodicity to "2/year" - save the subscription - reopen it and check the value is labelled "2/year" Signed-off-by: David Cook <dcook@prosentient.com.au> Trivial change. Works as described.
Created attachment 18018 [details] [review] Bug 10186: Fix a typo in subscription-add.tt : 2/years should be 2/year In subscription-add.tt dropdown list for periodiciy, the description for 9 value should be "2/year" (2 issues each year) At present, if the option value is selected, it is "2/years". This patch supresses the "s" after "year". To test : - in a subscription, change periodicity to "2/year" - save the subscription - reopen it and check the value is labelled "2/year" Signed-off-by: David Cook <dcook@prosentient.com.au> Trivial change. Works as described. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Passed QA
Pushed to master. Thanks, Mathieu!
This patch has been pushed to 3.12.x, will be in 3.12.1.
This patch has been pushed to 3.10.x, will be in 3.10.7.
Pushed to 3.8.x, will be in 3.8.14.