Bug 10201 - Old OPAC patron update system should be removed
Summary: Old OPAC patron update system should be removed
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low major (vote)
Assignee: Owen Leonard
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-06 14:00 UTC by Owen Leonard
Modified: 2013-12-05 20:09 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 10201 - Old OPAC patron update system should be removed (29.89 KB, patch)
2013-05-06 15:51 UTC, Owen Leonard
Details | Diff | Splinter Review
[SIGNED OFF] Bug 10201 - Old OPAC patron update system should be removed (29.90 KB, patch)
2013-05-07 13:09 UTC, Mirko Tietgen
Details | Diff | Splinter Review
Bug 10201 [Follow-up] Old OPAC patron update system should be removed (1.72 KB, patch)
2013-05-07 16:15 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 10201 [Follow-up] Old OPAC patron update system should be removed (1.75 KB, patch)
2013-05-07 19:15 UTC, Mirko Tietgen
Details | Diff | Splinter Review
[PASSED QA] Bug 10201 [Follow-up] Old OPAC patron update system should be removed (1.91 KB, patch)
2013-05-08 06:10 UTC, Katrin Fischer
Details | Diff | Splinter Review
[PASSED QA] Bug 10201 - Old OPAC patron update system should be removed (30.00 KB, patch)
2013-05-08 06:11 UTC, Katrin Fischer
Details | Diff | Splinter Review
[PASSED QA] Bug 10201 [Follow-up] Old OPAC patron update system should be removed (1.91 KB, patch)
2013-05-08 06:11 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2013-05-06 14:00:36 UTC
With the addition of opac-memberentry.pl and the patron update moderation system in the staff client the old system should be removed: opac-userdetails.pl and opac-userupdate.pl.

Several OPAC templates link to these pages even though they should be obsolete.
Comment 1 Owen Leonard 2013-05-06 15:51:43 UTC Comment hidden (obsolete)
Comment 2 Mirko Tietgen 2013-05-07 13:09:23 UTC Comment hidden (obsolete)
Comment 3 Owen Leonard 2013-05-07 16:15:17 UTC Comment hidden (obsolete)
Comment 4 Mirko Tietgen 2013-05-07 19:15:21 UTC Comment hidden (obsolete)
Comment 5 Katrin Fischer 2013-05-08 06:10:06 UTC Comment hidden (obsolete)
Comment 6 Katrin Fischer 2013-05-08 06:11:17 UTC
Created attachment 18008 [details] [review]
[PASSED QA] Bug 10201 - Old OPAC patron update system should be removed

The old pages for viewing and updating patron details in the OPAC have
been superceded by the new script opac-memberentry.pl. This patch
removes he old scripts and templates and corrects links to them.

This patch also removes reference to opac-userupdate.tt from
opac-patron-image.pl  and replaces the authentication process with one
which uses check_cookie_auth, based on the example of opac-tags.pl.

To test, edit a patron record and set the "Gone no address" flag. Log in
to the OPAC with that account and view the patron details page. The
warning about out of date contact information should link to the new
update page.

Next, attempt to place a hold. You should see the same warning, and it
should also link to the new update page.

Test the display of patron images: Log in as a user who has an image
associated with their account and navigate to
/cgi-bin/koha/opac-patron-image.pl. Their patron image should display.

A search of Koha source files should return no results for the missing
scripts or templates.

Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Comments on second patch.
Comment 7 Katrin Fischer 2013-05-08 06:11:26 UTC
Created attachment 18009 [details] [review]
[PASSED QA] Bug 10201 [Follow-up] Old OPAC patron update system should be removed

The previous patch missed removal of one template, kohaerror.tt, which
was used only by opac-userupdate.pl. This patch removes it.

To test, apply the patch and search Koha source files for references to
kohaerror. There should be none.

Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
All tests and QA script pass. Updating the German po files
with this patch applied no new strings appeared.
Comment 8 Jared Camins-Esakov 2013-05-12 13:54:36 UTC
This patch has been pushed to master and 3.12.x.
Comment 9 Chris Cormack 2013-05-13 09:29:50 UTC
Not needed for 3.10.x and below