Bug 10204 - Patron image no longer appears in the OPAC
Summary: Patron image no longer appears in the OPAC
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Owen Leonard
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-06 15:57 UTC by Owen Leonard
Modified: 2013-12-05 20:09 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 10204 - Patron image no longer appears in the OPAC (6.18 KB, patch)
2013-05-06 16:44 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 10204 - Patron image no longer appears in the OPAC (6.19 KB, patch)
2013-05-07 13:23 UTC, Mirko Tietgen
Details | Diff | Splinter Review
[PASSED QA] Bug 10204 - Patron image no longer appears in the OPAC (6.37 KB, patch)
2013-05-08 05:52 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2013-05-06 15:57:20 UTC
With the replacement of opac-userupdate.pl with opac-memberentry.pl there is now no place where the patron will see their patron image. The patron image should be added to opac-memberentry.pl in order to maintain the functionality of the previous version.
Comment 1 Owen Leonard 2013-05-06 16:44:14 UTC Comment hidden (obsolete)
Comment 2 Mirko Tietgen 2013-05-07 13:23:07 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2013-05-08 05:52:57 UTC
Created attachment 18006 [details] [review]
[PASSED QA] Bug 10204 - Patron image no longer appears in the OPAC

With the addition of opac-memberentry.pl to the OPAC we lost a way to
display the image associated with a patron's account. This patch adds
display of the patron image to opac-memberentry.pl now that
opac-userdetails.pl and opac-userupdate.pl are deprecated.

To test:

1. Log into the OPAC as a patron who has an image associated with their
   account. View the "my personal details" tab and confirm that the
   patron image appears with and without OPACPatronDetails enabled.

2. Log into the OPAC as a patron who has no image associated with their
   account. View the "my personal details" tab and confirm that the
   layout looks correct.

3. Turn off OPACpatronimages and confirm that the "my personal details"
   page looks correct.

Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Tested with OpacPatronDetails and OpacPatronImags turned on/off
and it's working well.
Template only changes.
Comment 4 Katrin Fischer 2013-05-08 05:54:37 UTC
I ran the translate update process after applying this patch and 3 strings go fuzzy, but those don't contain translatable text. Example:

"%s [%% UNLESS hidden.defined('title') && hidden.defined('surname') && hidden.defined('firstname') && hidden.defined('dateofbirth') && hidden.defined('initials') && hidden.defined('othernames') && hidden.defined('sex') %%] "

So I guess this should be safe for 3.12.
Comment 5 Jared Camins-Esakov 2013-05-08 13:49:31 UTC
This patch has been pushed to master and 3.12.x.
Comment 6 Chris Cormack 2013-05-12 03:12:33 UTC
Not needed for 3.10.x