With the replacement of opac-userupdate.pl with opac-memberentry.pl there is now no place where the patron will see their patron image. The patron image should be added to opac-memberentry.pl in order to maintain the functionality of the previous version.
Created attachment 17965 [details] [review] Bug 10204 - Patron image no longer appears in the OPAC With the addition of opac-memberentry.pl to the OPAC we lost a way to display the image associated with a patron's account. This patch adds display of the patron image to opac-memberentry.pl now that opac-userdetails.pl and opac-userupdate.pl are deprecated. To test: 1. Log into the OPAC as a patron who has an image associated with their account. View the "my personal details" tab and confirm that the patron image appears with and without OPACPatronDetails enabled. 2. Log into the OPAC as a patron who has no image associated with their account. View the "my personal details" tab and confirm that the layout looks correct. 3. Turn off OPACpatronimages and confirm that the "my personal details" page looks correct.
Created attachment 17980 [details] [review] Bug 10204 - Patron image no longer appears in the OPAC With the addition of opac-memberentry.pl to the OPAC we lost a way to display the image associated with a patron's account. This patch adds display of the patron image to opac-memberentry.pl now that opac-userdetails.pl and opac-userupdate.pl are deprecated. To test: 1. Log into the OPAC as a patron who has an image associated with their account. View the "my personal details" tab and confirm that the patron image appears with and without OPACPatronDetails enabled. 2. Log into the OPAC as a patron who has no image associated with their account. View the "my personal details" tab and confirm that the layout looks correct. 3. Turn off OPACpatronimages and confirm that the "my personal details" page looks correct. Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>
Created attachment 18006 [details] [review] [PASSED QA] Bug 10204 - Patron image no longer appears in the OPAC With the addition of opac-memberentry.pl to the OPAC we lost a way to display the image associated with a patron's account. This patch adds display of the patron image to opac-memberentry.pl now that opac-userdetails.pl and opac-userupdate.pl are deprecated. To test: 1. Log into the OPAC as a patron who has an image associated with their account. View the "my personal details" tab and confirm that the patron image appears with and without OPACPatronDetails enabled. 2. Log into the OPAC as a patron who has no image associated with their account. View the "my personal details" tab and confirm that the layout looks correct. 3. Turn off OPACpatronimages and confirm that the "my personal details" page looks correct. Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Tested with OpacPatronDetails and OpacPatronImags turned on/off and it's working well. Template only changes.
I ran the translate update process after applying this patch and 3 strings go fuzzy, but those don't contain translatable text. Example: "%s [%% UNLESS hidden.defined('title') && hidden.defined('surname') && hidden.defined('firstname') && hidden.defined('dateofbirth') && hidden.defined('initials') && hidden.defined('othernames') && hidden.defined('sex') %%] " So I guess this should be safe for 3.12.
This patch has been pushed to master and 3.12.x.
Not needed for 3.10.x