When looking at the patron details in the staff client you don't see the holds expiration date, but you do see all the other dates (placed, suspension) We should see the same here: /cgi-bin/koha/circ/circulation.pl?borrowernumber=51 that we see here: /cgi-bin/koha/reserve/request.pl?biblionumber=3174 When it relates to hold dates.
Created attachment 18118 [details] [review] Bug 10221 - hold expiration doesn't show on patron's list of holds When viewing the list of a patron's holds on the circulation page or the patron detail page the table of holds doesn't display the holds expiration date, if present. This patch adds display of the hold expiration date. To test, place a hold for a patron and set an expiration date for it. View the patron's existing holds on both circulation.pl and moremember.pl. The expiration date you chose should appear in the table of information about existing holds.
Created attachment 18120 [details] [review] [SIGNED-OFF] Bug 10221 - hold expiration doesn't show on patron's list of holds When viewing the list of a patron's holds on the circulation page or the patron detail page the table of holds doesn't display the holds expiration date, if present. This patch adds display of the hold expiration date. To test, place a hold for a patron and set an expiration date for it. View the patron's existing holds on both circulation.pl and moremember.pl. The expiration date you chose should appear in the table of information about existing holds. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> works great
QA comment: The patch adds a "expiration" column for holds tables on moremember and circulation pages. Works as expected. Marked as Passed QA.
Created attachment 18742 [details] [review] Bug 10221 - hold expiration doesn't show on patron's list of holds When viewing the list of a patron's holds on the circulation page or the patron detail page the table of holds doesn't display the holds expiration date, if present. This patch adds display of the hold expiration date. To test, place a hold for a patron and set an expiration date for it. View the patron's existing holds on both circulation.pl and moremember.pl. The expiration date you chose should appear in the table of information about existing holds. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> works great Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Pushed to master. Thanks, Owen!
This patch has been pushed to 3.12.x, will be in 3.12.1. I consider this an usability bugfix. Thanks Owen!
Would it be possible to have it in 3.10 too ? One of our customer would be delighted :-)
Created attachment 20759 [details] [review] [3.10.x] Bug 10221 - hold expiration doesn't show on patron's list of holds When viewing the list of a patron's holds on the circulation page or the patron detail page the table of holds doesn't display the holds expiration date, if present. This patch adds display of the hold expiration date. To test, place a hold for a patron and set an expiration date for it. View the patron's existing holds on both circulation.pl and moremember.pl. The expiration date you chose should appear in the table of information about existing holds.