Bug 10226 - suspended holds still show not available
Summary: suspended holds still show not available
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Hold requests (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Kyle M Hall
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-10 14:38 UTC by Nicole C. Engard
Modified: 2015-06-04 23:33 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 10226 - suspended holds still show not available (2.70 KB, patch)
2014-08-27 12:54 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 10226 - suspended holds still show not available (2.70 KB, patch)
2014-08-27 12:57 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 10226 - suspended holds still show not available (2.75 KB, patch)
2014-08-27 23:31 UTC, Chris Cormack
Details | Diff | Splinter Review
[PASSED QA] Bug 10226 - suspended holds still show not available (2.85 KB, patch)
2014-09-08 21:05 UTC, Katrin Fischer
Details | Diff | Splinter Review
Bug 10226 - suspended holds still show not available (2.90 KB, patch)
2014-09-10 14:23 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 10226: Add unit tests for GetReservesFromItemnumber (1.45 KB, patch)
2014-09-10 14:23 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nicole C. Engard 2013-05-10 14:38:19 UTC
See here: http://screencast.com/t/4ZfelnlJ 

If you suspend a hold, the item does not show Available.  It still shows the person next in line, who isn't eligible for the hold yet because of the suspension.  This is not the case for a delayed hold, where you originally place the hold and tell it not to start until a future date.  If you do that, it shows as Available.  This is confusing and inconsistent.
Comment 1 Kyle M Hall 2014-08-27 12:54:53 UTC Comment hidden (obsolete)
Comment 2 Kyle M Hall 2014-08-27 12:57:15 UTC Comment hidden (obsolete)
Comment 3 Chris Cormack 2014-08-27 23:31:20 UTC Comment hidden (obsolete)
Comment 4 Katrin Fischer 2014-09-08 20:49:11 UTC
Hi Kyle, could you back this up by a regression test please?
Comment 5 Katrin Fischer 2014-09-08 21:05:50 UTC Comment hidden (obsolete)
Comment 6 Jonathan Druart 2014-09-10 14:23:02 UTC
(In reply to Katrin Fischer from comment #4)
> Hi Kyle, could you back this up by a regression test please?

I started to QA this one and didn't see you did it!
I was writing unit tests when I saw your comment.
They are coming...

Marked as Passed QA.
Comment 7 Jonathan Druart 2014-09-10 14:23:25 UTC
Created attachment 31504 [details] [review]
Bug 10226 - suspended holds still show not available

If you suspend a hold, the item does not show Available.  It still shows
the person next in line, who isn't eligible for the hold yet because of
the suspension.  This is not the case for a delayed hold, where you
originally place the hold and tell it not to start until a future date.
If you do that, it shows as Available.  This is confusing and
inconsistent.

Test Plan:
1) Create an item level suspended hold for a record with no other holds
2) Note in the record details that the hold shows an item level hold
3) Apply this patch
4) Refresh the record details page, note the item is "Available"
5) Optional: prove t/db_dependent/Holds.t t/db_dependent/Reserves.t

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works as described, passes all tests and QA script.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 8 Jonathan Druart 2014-09-10 14:23:32 UTC
Created attachment 31505 [details] [review]
Bug 10226: Add unit tests for GetReservesFromItemnumber

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 9 Tomás Cohen Arazi 2014-09-14 05:06:33 UTC
Patch pushed to master.

Thanks Kyle and Jonathan!