See here: http://screencast.com/t/4ZfelnlJ If you suspend a hold, the item does not show Available. It still shows the person next in line, who isn't eligible for the hold yet because of the suspension. This is not the case for a delayed hold, where you originally place the hold and tell it not to start until a future date. If you do that, it shows as Available. This is confusing and inconsistent.
Created attachment 31183 [details] [review] Bug 10226 - suspended holds still show not available If you suspend a hold, the item does not show Available. It still shows the person next in line, who isn't eligible for the hold yet because of the suspension. This is not the case for a delayed hold, where you originally place the hold and tell it not to start until a future date. If you do that, it shows as Available. This is confusing and inconsistent. Test Plan: 1) Create an item level suspended hold for a record with no other holds 2) Note in the record details that the hold shows an item level hold 3) Apply this patch 4) Refresh the record details page, note the item is "Available" 5) Optional: prove t/db_dependent/Holds.t t/db_dependent/Reserves.t
Created attachment 31185 [details] [review] Bug 10226 - suspended holds still show not available If you suspend a hold, the item does not show Available. It still shows the person next in line, who isn't eligible for the hold yet because of the suspension. This is not the case for a delayed hold, where you originally place the hold and tell it not to start until a future date. If you do that, it shows as Available. This is confusing and inconsistent. Test Plan: 1) Create an item level suspended hold for a record with no other holds 2) Note in the record details that the hold shows an item level hold 3) Apply this patch 4) Refresh the record details page, note the item is "Available" 5) Optional: prove t/db_dependent/Holds.t t/db_dependent/Reserves.t
Created attachment 31217 [details] [review] Bug 10226 - suspended holds still show not available If you suspend a hold, the item does not show Available. It still shows the person next in line, who isn't eligible for the hold yet because of the suspension. This is not the case for a delayed hold, where you originally place the hold and tell it not to start until a future date. If you do that, it shows as Available. This is confusing and inconsistent. Test Plan: 1) Create an item level suspended hold for a record with no other holds 2) Note in the record details that the hold shows an item level hold 3) Apply this patch 4) Refresh the record details page, note the item is "Available" 5) Optional: prove t/db_dependent/Holds.t t/db_dependent/Reserves.t Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Hi Kyle, could you back this up by a regression test please?
Created attachment 31475 [details] [review] [PASSED QA] Bug 10226 - suspended holds still show not available If you suspend a hold, the item does not show Available. It still shows the person next in line, who isn't eligible for the hold yet because of the suspension. This is not the case for a delayed hold, where you originally place the hold and tell it not to start until a future date. If you do that, it shows as Available. This is confusing and inconsistent. Test Plan: 1) Create an item level suspended hold for a record with no other holds 2) Note in the record details that the hold shows an item level hold 3) Apply this patch 4) Refresh the record details page, note the item is "Available" 5) Optional: prove t/db_dependent/Holds.t t/db_dependent/Reserves.t Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described, passes all tests and QA script.
(In reply to Katrin Fischer from comment #4) > Hi Kyle, could you back this up by a regression test please? I started to QA this one and didn't see you did it! I was writing unit tests when I saw your comment. They are coming... Marked as Passed QA.
Created attachment 31504 [details] [review] Bug 10226 - suspended holds still show not available If you suspend a hold, the item does not show Available. It still shows the person next in line, who isn't eligible for the hold yet because of the suspension. This is not the case for a delayed hold, where you originally place the hold and tell it not to start until a future date. If you do that, it shows as Available. This is confusing and inconsistent. Test Plan: 1) Create an item level suspended hold for a record with no other holds 2) Note in the record details that the hold shows an item level hold 3) Apply this patch 4) Refresh the record details page, note the item is "Available" 5) Optional: prove t/db_dependent/Holds.t t/db_dependent/Reserves.t Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described, passes all tests and QA script. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Created attachment 31505 [details] [review] Bug 10226: Add unit tests for GetReservesFromItemnumber Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Patch pushed to master. Thanks Kyle and Jonathan!