Bug 10233 - Toolbar background missing from staff client catalogue page
Summary: Toolbar background missing from staff client catalogue page
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: master
Hardware: All All
: P5 - low trivial (vote)
Assignee: Owen Leonard
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-13 00:36 UTC by David Cook
Modified: 2013-12-05 20:09 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 10233 - Toolbar background missing from staff client catalogue page (1.45 KB, patch)
2013-05-13 14:00 UTC, Owen Leonard
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 10233 - Toolbar background missing from staff client catalogue page (1.48 KB, patch)
2013-05-14 04:47 UTC, Nicole C. Engard
Details | Diff | Splinter Review
[PASSED QA] Bug 10233 - Toolbar background missing from staff client catalogue page (1.60 KB, patch)
2013-05-14 06:32 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description David Cook 2013-05-13 00:36:48 UTC
Currently, the toolbar containing the buttons "New Record" and "Z39.50 search" is missing a background. Before we moved from YUI to Bootstrap, there was an extra div#toolbar wrapping the button group, but that appears to have vanished (and with it the background).

We might be able to just change the current id from "newmenuc" to "toolbar", since the javascript that touched "newmenuc" seems to have been removed from the page as well (since it cleared the newmenuc div so that the plain html could be replaced with yui buttons).

However, I'm loathe to do that without making sure that no existing functionality would break from doing that. It might be an idea to just wrap that div with a div#toolbar again to get that background back.
Comment 1 Owen Leonard 2013-05-13 14:00:24 UTC Comment hidden (obsolete)
Comment 2 Nicole C. Engard 2013-05-14 04:47:49 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2013-05-14 06:32:20 UTC
Created attachment 18128 [details] [review]
[PASSED QA] Bug 10233 - Toolbar background missing from staff client catalogue page

The toolbar on the cataloging home page lacks the standard toolbar id,
resulting in an inconsistent appearance. This patch adds the correct id.

To test, apply the patch, clear your browser cache, and view the
cataloging home page (cataloguing/addbooks.pl). The toolbar should look
like other toolbars in Koha (for instance, members/members-home.pl).

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Template change only, no string changed involved.
Works as described.
Comment 4 Jared Camins-Esakov 2013-05-14 12:18:04 UTC
This patch has been pushed to master and 3.12.x.