The table with the id 'holdingst' in koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt lacks some classes which would help in styling and JS manipulation. Robin started in http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9736 Some classes were added in http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8597 I have added all the classes missing from 8597 that were in Robin's original work for 9736, I made one change which was to change 'vol_no' to 'vol_info' to be consistent with 8597.
Created attachment 18146 [details] [review] adding OPAC detail items table classes As master is significantly different to 3.10 in this area I will create a separate bug with the 3.10 equivalent of this patch. I also added in the id for barcode of 'item_barcode' as this was in 3.10 and seems to not be in 3.12, I will have to check why it was removed to see if this will cause an issue.
3.10 patch attached at http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10246
Created attachment 18733 [details] [review] Bug 10245 adding OPAC detail items table classes Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Classes now appear on <th> as well for easy styling.
Created attachment 19025 [details] [review] Bug 10245 adding OPAC detail items table classes Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Classes now appear on <th> as well for easy styling. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Passes koha-qa.pl, template changes only. Adds classes and id's to table headers, makes no other changes.
Pushed to master. Thanks, Chris!
This patch has been pushed to 3.12.x, will be in 3.12.2. Thanks Chris! Note: it seems to me that as of master/3.12.x there are still 2 columns without class and id.