Bug 10245 - OPAC items table CSS classes
Summary: OPAC items table CSS classes
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Chris Hall
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-15 07:25 UTC by Chris Hall
Modified: 2014-12-07 20:02 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
adding OPAC detail items table classes (2.57 KB, patch)
2013-05-15 07:35 UTC, Chris Hall
Details | Diff | Splinter Review
Bug 10245 adding OPAC detail items table classes (2.69 KB, patch)
2013-06-07 12:27 UTC, Jared Camins-Esakov
Details | Diff | Splinter Review
Bug 10245 adding OPAC detail items table classes (2.84 KB, patch)
2013-06-14 18:44 UTC, Kyle M Hall
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Hall 2013-05-15 07:25:42 UTC
The table with the id 'holdingst' in koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt lacks some classes which would help in styling and JS manipulation.

Robin started in http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9736
Some classes were added in http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8597

I have added all the classes missing from 8597 that were in Robin's original work for 9736, I made one change which was to change 'vol_no' to 'vol_info' to be consistent with 8597.
Comment 1 Chris Hall 2013-05-15 07:35:05 UTC Comment hidden (obsolete)
Comment 2 Chris Hall 2013-05-15 07:39:22 UTC
3.10 patch attached at http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10246
Comment 3 Jared Camins-Esakov 2013-06-07 12:27:19 UTC Comment hidden (obsolete)
Comment 4 Kyle M Hall 2013-06-14 18:44:02 UTC
Created attachment 19025 [details] [review]
Bug 10245 adding OPAC detail items table classes

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Classes now appear on <th> as well for easy styling.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Passes koha-qa.pl, template changes only. Adds classes and id's to table
headers, makes no other changes.
Comment 5 Galen Charlton 2013-06-14 21:44:50 UTC
Pushed to master.  Thanks, Chris!
Comment 6 Tomás Cohen Arazi 2013-07-01 19:06:43 UTC
This patch has been pushed to 3.12.x, will be in 3.12.2.

Thanks Chris!
Note: it seems to me that as of master/3.12.x there are still 2 columns without class and id.