http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt Untranslatable strings are: 178 Your rating 343,354 Go to detail 328 Click to forward the list to 306 Click to rewind the list to Also some CSS is hardcoded, as a background color on line 347 if (highlIndex && i == index) li.css("backgroundColor", "#DDDDDD"); I think one possible solution would be to use variables in those places and then have something like var sth = _("Go to detail")
Also 'by' in a few lines. Everything that builds HTML-Tags with Javascript is a bit suspicious.
Created attachment 18235 [details] [review] Bug 10249: Fix untranslatable strings in OPAC detail page Star ratings feature: - Your CGI session cookie is not current. Please refresh the page and try again. - average rating: - your rating: Browse results feature: - Click to rewind the list to - See biblio - with biblionumber - by (between title and author) - Click to forward the list to - Go to detail To test: - Update the po file using 'perl translate update <langcode>' - Translate all new strings, maybe mark them with XX to make it easier to find them - Install the updated translation file using 'perl translate install <langcode>' - Test the ratings and browse results features in the OPAC detail page - Verify everything is still working/displaying like it should - Check that you don't find any unstranslated strings/terms Some hints where the changes are: - Change an existing rating - the average and your rating will change - Browse result list and check mouse over tooltips for all links
Created attachment 18646 [details] [review] Bug 10249: Fix untranslatable strings in OPAC detail page Star ratings feature: - Your CGI session cookie is not current. Please refresh the page and try again. - average rating: - your rating: Browse results feature: - Click to rewind the list to - See biblio - with biblionumber - by (between title and author) - Click to forward the list to - Go to detail To test: - Update the po file using 'perl translate update <langcode>' - Translate all new strings, maybe mark them with XX to make it easier to find them - Install the updated translation file using 'perl translate install <langcode>' - Test the ratings and browse results features in the OPAC detail page - Verify everything is still working/displaying like it should - Check that you don't find any unstranslated strings/terms Some hints where the changes are: - Change an existing rating - the average and your rating will change - Browse result list and check mouse over tooltips for all links Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Strings are now translated, and no emergent JS errors have revealed themselves.
Created attachment 18665 [details] [review] Bug 10249: Fix untranslatable strings in OPAC detail page Star ratings feature: - Your CGI session cookie is not current. Please refresh the page and try again. - average rating: - your rating: Browse results feature: - Click to rewind the list to - See biblio - with biblionumber - by (between title and author) - Click to forward the list to - Go to detail To test: - Update the po file using 'perl translate update <langcode>' - Translate all new strings, maybe mark them with XX to make it easier to find them - Install the updated translation file using 'perl translate install <langcode>' - Test the ratings and browse results features in the OPAC detail page - Verify everything is still working/displaying like it should - Check that you don't find any unstranslated strings/terms Some hints where the changes are: - Change an existing rating - the average and your rating will change - Browse result list and check mouse over tooltips for all links Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Strings are now translated, and no emergent JS errors have revealed themselves. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Pushed to master. Thanks, Katrin!
This patch has been pushed to 3.12.x, will be in 3.12.1. Thanks Katrin!.
Pushed to 3.10.x, will be in 3.10.7
Pushed to 3.8.x, will be in 3.8.14