typo in help/reports/guided_reports.tt : CreditXXX should be credit</li> M. Saby
also : missing space after "=" in this line <li>W =Waiting: the reserve is linked to an item, is at the pickup branch, and is waiting on the hold shelf</li>
in the same file, probably an other typo, but I am not sure : 6 = Delete should be 6 = Deleted
Another typo: "What are the possible codes for the area field in the reports_dictionary table?" should be "What are the possible codes for the report_area field in the reports_dictionary table?"
1 other typos : What are the possible codes for the status field in the serial table"? should be What are the possible codes for the status field in the serial table?
(In reply to comment #0) > typo in help/reports/guided_reports.tt : > > CreditXXX should be credit</li> > > M. Saby Actually it's right - it's going to say Credit and then the XX is the value after it.
(In reply to comment #2) > in the same file, probably an other typo, but I am not sure : > > 6 = Delete > > should be > > 6 = Deleted Nope, that's the value that's stored in the DB.
Created attachment 18254 [details] [review] Bug 10250: Fix typos in guided reports help file This is a string patch that fixes typos in the guided reports help file. To test: * Go to the guided reports page * Click help * Confirm text is right
Not sure CreditXXX is right : - HTML closing Tag </li> missing - I don't know how to translate CreditXXX in french Mathieu
The closing <li> is after the </ul> as it should be. And the way the data is stored is Credit and then a code - all one word with no spaces. How would be a better way to denote this?
Oh, I looked to quickly. I did not understand the structure of the code. Of course you are right! We'll find a way to translate CreditXXX (I translated in french as "Credit </li>" - SHAME ON ME!) Mathieu
By the way, CreditXXX is the only value begining with an Uppercase in the list. It is not a typo ? http://manual.koha-community.org/3.10/en/reportsfaq.html#statscodefaq Mathieu
Mathieu, are you sure those should be translated?
(In reply to comment #12) > Mathieu, are you sure those should be translated? I was just coming here to say that. I didn't think about it yesterday, but these are database values, they won't be different if you're using a different language pack - they should not be translated I would think. Nicole
Created attachment 18766 [details] [review] Bug 10250: Fix typos in guided reports help file This is a string patch that fixes typos in the guided reports help file. To test: * Go to the guided reports page * Click help * Confirm text is right Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Created attachment 18783 [details] [review] Bug 10250: Fix typos in guided reports help file This is a string patch that fixes typos in the guided reports help file. To test: * Go to the guided reports page * Click help * Confirm text is right Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Pushed to master. Thanks, Nicole!
This patch has been pushed to 3.12.x, will be in 3.12.1. Thanks Nicole!