Bug 10250 - typos in help/reports/guided_reports.tt
Summary: typos in help/reports/guided_reports.tt
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Documentation (show other bugs)
Version: 3.12
Hardware: All All
: P5 - low minor (vote)
Assignee: Nicole C. Engard
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-15 15:03 UTC by Mathieu Saby
Modified: 2014-12-07 20:02 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: String patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 10250: Fix typos in guided reports help file (2.32 KB, patch)
2013-05-20 15:00 UTC, Nicole C. Engard
Details | Diff | Splinter Review
Bug 10250: Fix typos in guided reports help file (2.38 KB, patch)
2013-06-08 01:19 UTC, Jared Camins-Esakov
Details | Diff | Splinter Review
Bug 10250: Fix typos in guided reports help file (2.45 KB, patch)
2013-06-08 05:19 UTC, Chris Cormack
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Mathieu Saby 2013-05-15 15:03:52 UTC
typo in help/reports/guided_reports.tt :

CreditXXX should be credit</li>

M. Saby
Comment 1 Mathieu Saby 2013-05-15 15:09:14 UTC
also : missing space after "=" in this line

	<li>W =Waiting: the reserve is linked to an item, is at the pickup branch, and is waiting on the hold shelf</li>
Comment 2 Mathieu Saby 2013-05-15 15:14:29 UTC
in the same file, probably an other typo, but I am not sure : 

6 = Delete

should be 

6 = Deleted
Comment 3 Mathieu Saby 2013-05-15 15:23:43 UTC
Another typo:

"What are the possible codes for the area field in the reports_dictionary table?"

should be

"What are the possible codes for the report_area field in the reports_dictionary table?"
Comment 4 Mathieu Saby 2013-05-15 16:26:28 UTC
1 other typos : 

What are the possible codes for the status field in the serial table"?

should be

What are the possible codes for the status field in the serial table?
Comment 5 Nicole C. Engard 2013-05-20 14:44:03 UTC
(In reply to comment #0)
> typo in help/reports/guided_reports.tt :
> 
> CreditXXX should be credit</li>
> 
> M. Saby

Actually it's right - it's going to say Credit and then the XX is the value after it.
Comment 6 Nicole C. Engard 2013-05-20 14:45:03 UTC
(In reply to comment #2)
> in the same file, probably an other typo, but I am not sure : 
> 
> 6 = Delete
> 
> should be 
> 
> 6 = Deleted

Nope, that's the value that's stored in the DB.
Comment 7 Nicole C. Engard 2013-05-20 15:00:35 UTC Comment hidden (obsolete)
Comment 8 Mathieu Saby 2013-05-20 17:07:52 UTC
Not sure CreditXXX is right : 
- HTML closing Tag </li> missing
- I don't know how to translate CreditXXX in french

Mathieu
Comment 9 Nicole C. Engard 2013-05-20 21:01:00 UTC
The closing <li> is after the </ul> as it should be.  And the way the data is stored is Credit and then a code - all one word with no spaces. How would be a better way to denote this?
Comment 10 Mathieu Saby 2013-05-20 21:11:52 UTC
Oh, I looked to quickly. I did not understand the structure of the code. Of course you are right!
We'll find a way to translate CreditXXX (I translated in french as "Credit </li>" - SHAME ON ME!)

Mathieu
Comment 11 Mathieu Saby 2013-05-20 21:17:29 UTC
By the way, CreditXXX is the only value begining with an Uppercase in the list. 
It is not a typo ?
http://manual.koha-community.org/3.10/en/reportsfaq.html#statscodefaq

Mathieu
Comment 12 Katrin Fischer 2013-05-20 22:37:24 UTC
Mathieu, are you sure those should be translated?
Comment 13 Nicole C. Engard 2013-05-21 10:36:02 UTC
(In reply to comment #12)
> Mathieu, are you sure those should be translated?


I was just coming here to say that. I didn't think about it yesterday, but these are database values, they won't be different if you're using a different language pack - they should not be translated I would think.

Nicole
Comment 14 Jared Camins-Esakov 2013-06-08 01:19:58 UTC Comment hidden (obsolete)
Comment 15 Chris Cormack 2013-06-08 05:19:26 UTC
Created attachment 18783 [details] [review]
Bug 10250: Fix typos in guided reports help file

This is a string patch that fixes typos in the guided reports
help file.

To test:

* Go to the guided reports page
* Click help
* Confirm text is right

Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Comment 16 Galen Charlton 2013-06-09 01:13:20 UTC
Pushed to master.  Thanks, Nicole!
Comment 17 Tomás Cohen Arazi 2013-06-11 18:35:18 UTC
This patch has been pushed to 3.12.x, will be in 3.12.1.

Thanks Nicole!