Created attachment 18179 [details] series display The subfields of the 830 are showing up without spaces in the series tag on the opac. See attached
Created attachment 18180 [details] marc for 830
I can reproduce this in master in both the OPAC and staff client but where this is happening in the xsl file I do not know.
Created attachment 18239 [details] [review] Bug 10265: Add missing spaces between label and content in XSLT view (780/785) To test: - Check OPAC and intranet XSLT view for a record that contains 780 and 785 fields. - Verify there is no space between the label and the content of the field. - Apply patch. - Verify the display both in intranet and OPAC is a little nicer now.
This patch doesn't solve the problem of the 830. Applied and both the staff and the OPAC have the spaces still missing.
Nicole, I attached the patch to the wrong bug - still working on this one.
Comment on attachment 18239 [details] [review] Bug 10265: Add missing spaces between label and content in XSLT view (780/785) >From 0a9055d0c36ef12d19da91b970f725dba2f6a6b5 Mon Sep 17 00:00:00 2001 >From: Katrin Fischer <Katrin.Fischer.83@web.de> >Date: Sun, 19 May 2013 12:16:16 +0200 >Subject: [PATCH] Bug 10265: Add missing spaces between label and content in > XSLT view (780/785) > >To test: >- Check OPAC and intranet XSLT view for a record that contains > 780 and 785 fields. >- Verify there is no space between the label and the content of the > field. >- Apply patch. >- Verify the display both in intranet and OPAC is a little nicer now. >--- > .../prog/en/xslt/MARC21slim2intranetDetail.xsl | 3 ++- > .../prog/en/xslt/MARC21slim2OPACDetail.xsl | 3 ++- > 2 files changed, 4 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl b/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl >index aeaa797..98d5742 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl >+++ b/koha-tmpl/intranet-tmpl/prog/en/xslt/MARC21slim2intranetDetail.xsl >@@ -741,6 +741,7 @@ > <span class="label">Separated from:</span> > </xsl:when> > </xsl:choose> >+ <xsl:text> </xsl:text> > <xsl:variable name="f780"> > <xsl:call-template name="subfieldSelect"> > <xsl:with-param name="codes">at</xsl:with-param> >@@ -800,8 +801,8 @@ > <xsl:when test="@ind2=8"> > <span class="label">Changed back to:</span> > </xsl:when> >- > </xsl:choose> >+ <xsl:text> </xsl:text> > <xsl:variable name="f785"> > <xsl:call-template name="subfieldSelect"> > <xsl:with-param name="codes">at</xsl:with-param> >diff --git a/koha-tmpl/opac-tmpl/prog/en/xslt/MARC21slim2OPACDetail.xsl b/koha-tmpl/opac-tmpl/prog/en/xslt/MARC21slim2OPACDetail.xsl >index 5130e8b..e1e6546 100644 >--- a/koha-tmpl/opac-tmpl/prog/en/xslt/MARC21slim2OPACDetail.xsl >+++ b/koha-tmpl/opac-tmpl/prog/en/xslt/MARC21slim2OPACDetail.xsl >@@ -847,6 +847,7 @@ > <span class="label">Separated from:</span> > </xsl:when> > </xsl:choose> >+ <xsl:text> </xsl:text> > <xsl:variable name="f780"> > <xsl:call-template name="subfieldSelect"> > <xsl:with-param name="codes">a_t</xsl:with-param> >@@ -907,8 +908,8 @@ > <xsl:when test="@ind2=8"> > <span class="label">Changed back to:</span> > </xsl:when> >- > </xsl:choose> >+ <xsl:text> </xsl:text> > <xsl:variable name="f785"> > <xsl:call-template name="subfieldSelect"> > <xsl:with-param name="codes">a_t</xsl:with-param> >-- >1.7.9.5
Some notes for reproducing this: - you need to make p and n visible in the MARC editor, to make it possible to catalog the attached example. - You also have to make sure you have a matching 490 field with the first indicator = 1, else the information is pulled from the 490 field.
The problem is somewhere in the part template that deals with the n and p subfields.
Do we only want spaces? Or is there some other punctuation needed between those fields?
Spaces should be sufficient, the cataloger should have entered the other punctuation: http://www.loc.gov/marc/bibliographic/bd830.html
The function chops off the other punctuation as far as I can see...
I will do some testing, it's a pretty old part of the XSLT code, maybe we can just do it completely different now.
I don't have time to work on this right now - maybe someone else wants to take it on.
I tried and failed... maybe someone else want to give it a try?
Created attachment 124060 [details] [review] Bug 10265: Keep punctuation for 8xx series added entry fields (MARC21) At the moment the punctuation entered for $n $p and is removed in the part template, which leads to displaying the subfields without any punctuation and spaces in between. To test: - Catalog records with various combinations of 8xx series added entry fields. Subfield a, t, n, p and v are the most important. - Verify the display in OPAC and staff is not great. - Apply the patch. - Verify the display in OPAC and staff is improved. For examples see: https://www.loc.gov/marc/bibliographic/bd80x83x.html Important note: At the moment 8xx series added entry fields will only display, when there is also a 490 ind. 1 = 1 field present.
Created attachment 124129 [details] [review] Bug 10265: Keep punctuation for 8xx series added entry fields (MARC21) At the moment the punctuation entered for $n $p and is removed in the part template, which leads to displaying the subfields without any punctuation and spaces in between. To test: - Catalog records with various combinations of 8xx series added entry fields. Subfield a, t, n, p and v are the most important. - Verify the display in OPAC and staff is not great. - Apply the patch. - Verify the display in OPAC and staff is improved. For examples see: https://www.loc.gov/marc/bibliographic/bd80x83x.html Important note: At the moment 8xx series added entry fields will only display, when there is also a 490 ind. 1 = 1 field present. Signed-off-by: Hayley Pelham <hayleypelham@catalyst.net.nz>
Thank you, Hayley!
Created attachment 124513 [details] [review] Bug 10265: Keep punctuation for 8xx series added entry fields (MARC21) At the moment the punctuation entered for $n $p and is removed in the part template, which leads to displaying the subfields without any punctuation and spaces in between. To test: - Catalog records with various combinations of 8xx series added entry fields. Subfield a, t, n, p and v are the most important. - Verify the display in OPAC and staff is not great. - Apply the patch. - Verify the display in OPAC and staff is improved. For examples see: https://www.loc.gov/marc/bibliographic/bd80x83x.html Important note: At the moment 8xx series added entry fields will only display, when there is also a 490 ind. 1 = 1 field present. Signed-off-by: Hayley Pelham <hayleypelham@catalyst.net.nz> Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi>
Created attachment 124514 [details] [review] Bug 10265: (QA follow-up) Make if-else checks consistent The != '' version doesn't check for the whitespace existing and thus might have added the punctuation without the partNumber or partName being inserted at all. Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi>
Pushed to master for 21.11, thanks to everybody involved!
Pushed to 21.05.x for 21.05.04
Pushed to 20.11.x for 20.11.10
Not backported to oldoldstable (20.05.x). Feel free to ask if it's needed.