Bug 10290 - UT: VirtualShelves.t needs to create its own data
Summary: UT: VirtualShelves.t needs to create its own data
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Test Suite (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Jonathan Druart
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on:
Blocks: 10273 10386 10499
  Show dependency treegraph
 
Reported: 2013-05-20 14:55 UTC by Jonathan Druart
Modified: 2014-12-07 20:02 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
MT10290: UT: VirtualShelves.t needs to create its own data (5.33 KB, patch)
2013-05-20 14:58 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 10290: UT: VirtualShelves.t needs to create its own data (5.39 KB, patch)
2013-05-24 23:14 UTC, Chris Cormack
Details | Diff | Splinter Review
Bug 10290: Followup for Virtualshelves.t (3.74 KB, patch)
2013-06-03 12:34 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 10290: UT: VirtualShelves.t needs to create its own data (5.49 KB, patch)
2013-06-03 12:34 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 10290: Followup for Virtualshelves.t (3.74 KB, patch)
2013-06-03 12:34 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2013-05-20 14:55:04 UTC
t/db_dependent/VirtualShelves.t depends on the Jenkins database.
We should create the data we want and delete them at the end.
Comment 1 Jonathan Druart 2013-05-20 14:58:16 UTC Comment hidden (obsolete)
Comment 2 Chris Cormack 2013-05-24 23:14:38 UTC Comment hidden (obsolete)
Comment 3 Marcel de Rooy 2013-06-03 12:06:46 UTC
QA: Looking at this one now.
Comment 4 Marcel de Rooy 2013-06-03 12:34:04 UTC Comment hidden (obsolete)
Comment 5 Marcel de Rooy 2013-06-03 12:34:25 UTC
Created attachment 18624 [details] [review]
Bug 10290: UT: VirtualShelves.t needs to create its own data

Try before the patch:
prove t/db_dependent/VirtualShelves.t

And after, it should produce:
  t/db_dependent/VirtualShelves.t .. ok
  All tests successful.
  Files=1, Tests=82,  6 wallclock secs ( 0.03 usr  0.00 sys +  0.46 cusr  0.03 csys =  0.52 CPU)
  Result: PASS

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 6 Marcel de Rooy 2013-06-03 12:34:28 UTC
Created attachment 18625 [details] [review]
Bug 10290: Followup for Virtualshelves.t

Put the 10 biblionumbers in a list
Add a FIXME for deleting shelves
Do temporary repair on duplicate name test (Followup via report 10386)

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 7 Marcel de Rooy 2013-06-03 12:39:01 UTC
QA Comment:
Works as advertised.
Leaving me only with the question if the borrowers from Jenkins are better than the biblios :)
Note that if I test with a small testdb without 10 borrowernumbers, some tests do also fail..

I have added a QA followup for the 10 biblionumbers in a list. And I fixed the sometimes failing test on duplicate list name. Will continue that fix under report 10386. Plus a fixme on why all my lists have been deleted :)

Galen: If you feel that this second QA followup still needs another signoff, please indicate so.

Passed QA
Comment 8 Galen Charlton 2013-06-03 14:40:10 UTC
Pushed to master.  Thanks, Jonathan and Marcel!
Comment 9 Tomás Cohen Arazi 2013-06-10 17:16:15 UTC
This patch has been pushed to 3.12.x, will be in 3.12.1.

I find them useful and am willing to have them in the stable branch (the same applies for the related ones if they get into master).
Comment 10 Bernardo Gonzalez Kriegel 2013-07-16 12:18:26 UTC
Pushed to 3.10.x, will be in 3.10.8
Comment 11 Chris Hall 2013-08-17 22:55:52 UTC
Pushed to 3.8.x, will be in 3.8.17