Bug 10296 - UT: db schemas are useless
Summary: UT: db schemas are useless
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Test Suite (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor (vote)
Assignee: Jonathan Druart
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-21 12:53 UTC by Jonathan Druart
Modified: 2014-12-07 20:03 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 10296: UT: db schemas are useless (174.24 KB, patch)
2013-05-21 12:57 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 10296: UT: t/data/db_schemas not needed (174.46 KB, patch)
2013-05-31 03:46 UTC, Galen Charlton
Details | Diff | Splinter Review
Bug 10296: UT: t/data/db_schemas not needed (174.50 KB, patch)
2013-06-08 04:04 UTC, Chris Cormack
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2013-05-21 12:53:59 UTC
3 files seem to be useless in t/data/db_schemas
Comment 1 Jonathan Druart 2013-05-21 12:57:25 UTC Comment hidden (obsolete)
Comment 2 Galen Charlton 2013-05-31 03:46:29 UTC Comment hidden (obsolete)
Comment 3 Chris Cormack 2013-06-08 04:04:42 UTC
Created attachment 18779 [details] [review]
Bug 10296: UT: t/data/db_schemas not needed

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

These were added with the intention of writing some
schema verification test cases, but if that idea
gets picked up again in the future, fresher copies
of kohastructure.sql can be obtained from Git.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Comment 4 Galen Charlton 2013-06-09 01:02:16 UTC
Pushed to master.  Thanks, Jonathan!
Comment 5 Tomás Cohen Arazi 2013-06-11 18:36:04 UTC
This patch has been pushed to 3.12.x, will be in 3.12.1.

Thanks Jonathan!
Comment 6 Bernardo Gonzalez Kriegel 2013-06-14 21:01:57 UTC
Pushed to 3.10.x, will be in 3.10.7
Comment 7 Chris Hall 2013-06-17 09:07:00 UTC
Pushed to 3.8.x, will be in 3.8.14