Bug 10315 - Use easier readable font for generated passwords
Summary: Use easier readable font for generated passwords
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact: Jonathan Druart
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-23 11:50 UTC by Katrin Fischer
Modified: 2014-12-07 20:02 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 10315 - Use easier readable font for generated passwords (1.59 KB, patch)
2013-05-23 16:49 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 10315 - Use easier readable font for generated passwords (1.62 KB, patch)
2013-05-29 21:05 UTC, Mirko Tietgen
Details | Diff | Splinter Review
Bug 10315 - Use easier readable font for generated passwords (1.67 KB, patch)
2013-06-14 12:10 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2013-05-23 11:50:24 UTC
We had a library reporting that they had problems telling apart small l and capital I in the font used when passwords are generated. Of course you can always generate another password, if you are not sure, but it would be nice if we could change the CSS to use a font where the letters are easier to distinguish.
Comment 1 Owen Leonard 2013-05-23 16:49:16 UTC Comment hidden (obsolete)
Comment 2 Mirko Tietgen 2013-05-29 21:05:50 UTC Comment hidden (obsolete)
Comment 3 Mirko Tietgen 2013-05-29 21:07:32 UTC
On a sidenote: Independently of using the patch or not, I could only generate one password. If I wanted to do it again, I had to reload the page. Is that the intended behaviour?
Comment 4 Owen Leonard 2013-05-29 23:25:15 UTC
(In reply to comment #3)
> I could only
> generate one password.

This is the way it has always worked, so I guess you could call it the intended behavior.
Comment 5 Jonathan Druart 2013-06-14 12:10:35 UTC
QA comment:
Simple patch, it changes font using css for inputs on the update pwd page.
Marked as Passed QA.
Comment 6 Jonathan Druart 2013-06-14 12:10:58 UTC
Created attachment 18994 [details] [review]
Bug 10315 - Use easier readable font for generated passwords

The text inputs on the change password form are not very big, and the
default sans-serif font isn't always good for showing unambiguous
characters. This patch sets a larger, monospace font for those fields.

To test, apply the patch, clear your browser cache, and open the patron
change password form (members/member-password.pl). The inputs should be
more readable, especially the password fields when you click to fill
with a randomly generated password.

Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 7 Galen Charlton 2013-06-14 15:18:14 UTC
Pushed to master.  Thanks, Owen!
Comment 8 Tomás Cohen Arazi 2013-07-01 19:08:01 UTC
This patch has been pushed to 3.12.x, will be in 3.12.2.

Thanks Owen!