We had a library reporting that they had problems telling apart small l and capital I in the font used when passwords are generated. Of course you can always generate another password, if you are not sure, but it would be nice if we could change the CSS to use a font where the letters are easier to distinguish.
Created attachment 18355 [details] [review] Bug 10315 - Use easier readable font for generated passwords The text inputs on the change password form are not very big, and the default sans-serif font isn't always good for showing unambiguous characters. This patch sets a larger, monospace font for those fields. To test, apply the patch, clear your browser cache, and open the patron change password form (members/member-password.pl). The inputs should be more readable, especially the password fields when you click to fill with a randomly generated password.
Created attachment 18482 [details] [review] Bug 10315 - Use easier readable font for generated passwords The text inputs on the change password form are not very big, and the default sans-serif font isn't always good for showing unambiguous characters. This patch sets a larger, monospace font for those fields. To test, apply the patch, clear your browser cache, and open the patron change password form (members/member-password.pl). The inputs should be more readable, especially the password fields when you click to fill with a randomly generated password. Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>
On a sidenote: Independently of using the patch or not, I could only generate one password. If I wanted to do it again, I had to reload the page. Is that the intended behaviour?
(In reply to comment #3) > I could only > generate one password. This is the way it has always worked, so I guess you could call it the intended behavior.
QA comment: Simple patch, it changes font using css for inputs on the update pwd page. Marked as Passed QA.
Created attachment 18994 [details] [review] Bug 10315 - Use easier readable font for generated passwords The text inputs on the change password form are not very big, and the default sans-serif font isn't always good for showing unambiguous characters. This patch sets a larger, monospace font for those fields. To test, apply the patch, clear your browser cache, and open the patron change password form (members/member-password.pl). The inputs should be more readable, especially the password fields when you click to fill with a randomly generated password. Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Pushed to master. Thanks, Owen!
This patch has been pushed to 3.12.x, will be in 3.12.2. Thanks Owen!