Created attachment 18352 [details] [review] Bug 10317: The parcel page display whatever if the invoiceid is unknown This patch fixes some stuffs on the parcel page. 1/ Removes dead code 2/ Display an error message if invoiceid is unset or not to refer to an invoice 3/ Fix a bug in the note ("change note" and "add note" links) Test plan: 1/ Try to call the invoice page with an existing invoiceid and check that order results are consistent. 2/ Try without invoiceid or a bad invoiceid and check that an error message is displayed. 3/ Add and change notes.
Patch tested with a sandbox, by Cedric Vita <cedric.vita@dracenie.com>
Created attachment 18491 [details] [review] Bug 10317: The parcel page display whatever if the invoiceid is unknown This patch fixes some stuffs on the parcel page. 1/ Removes dead code 2/ Display an error message if invoiceid is unset or not to refer to an invoice 3/ Fix a bug in the note ("change note" and "add note" links) Test plan: 1/ Try to call the invoice page with an existing invoiceid and check that order results are consistent. 2/ Try without invoiceid or a bad invoiceid and check that an error message is displayed. 3/ Add and change notes. Signed-off-by: Cedric Vita <cedric.vita@dracenie.com>
Created attachment 19045 [details] [review] [PASSED QA] Bug 10317: The parcel page display whatever if the invoiceid is unknown This patch fixes some stuffs on the parcel page. 1/ Removes dead code 2/ Display an error message if invoiceid is unset or not to refer to an invoice 3/ Fix a bug in the note ("change note" and "add note" links) Test plan: 1/ Try to call the invoice page with an existing invoiceid and check that order results are consistent. 2/ Try without invoiceid or a bad invoiceid and check that an error message is displayed. 3/ Add and change notes. Signed-off-by: Cedric Vita <cedric.vita@dracenie.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works nicely for all tests done. - parcel.pl with invalid invoicenumber gives a nice error message - parcel.pl with a valid invoicenumber looks normal - changing and editing order notes works well Passes QA script.
*** Bug 10536 has been marked as a duplicate of this bug. ***
Pushed to master. Thanks, Jonathan!
This patch has been pushed to 3.12.x, will be in 3.12.2. Thansk Jonathan!
Pushed to 3.10.x, will be in 3.10.8