Bug 10326 - bulkmarcimport.pl turns off CataloguingLog sys pref
Summary: bulkmarcimport.pl turns off CataloguingLog sys pref
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Command-line Utilities (show other bugs)
Version: master
Hardware: All All
: P5 - low minor (vote)
Assignee: Janusz Kaczmarek
QA Contact: Jonathan Druart
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-24 11:20 UTC by Janusz Kaczmarek
Modified: 2024-02-07 13:45 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Proposed patch (702 bytes, patch)
2013-05-24 11:23 UTC, Janusz Kaczmarek
Details | Diff | Splinter Review
Bug 10326: bulkmarcimport.pl doesn't restore value of CataloguingLog syspref (1.09 KB, patch)
2013-05-31 03:06 UTC, Galen Charlton
Details | Diff | Splinter Review
Bug 10326: bulkmarcimport.pl doesn't restore value of CataloguingLog syspref (1.15 KB, patch)
2013-05-31 08:13 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Janusz Kaczmarek 2013-05-24 11:20:34 UTC
The bulkmarcimport.pl script does not correctly restore the CataloguingLog system preference.

To reproduce: 
1) have CataloguingLog set to Log;
2) import some batch of bibliographic records with bulkmarcimport.pl 
3) check the state of CataloguingLog system preference -- it will be set to "Don't log".

A patch will follow.
Comment 1 Janusz Kaczmarek 2013-05-24 11:23:55 UTC Comment hidden (obsolete)
Comment 2 Galen Charlton 2013-05-31 03:06:10 UTC Comment hidden (obsolete)
Comment 3 Jonathan Druart 2013-05-31 08:12:23 UTC
sounds logical, marked as Passed QA.
Comment 4 Jonathan Druart 2013-05-31 08:13:19 UTC
Created attachment 18539 [details] [review]
Bug 10326: bulkmarcimport.pl doesn't restore value of CataloguingLog syspref

To test:

0) Don't apply the patch yet.
1) Have the CataloguingLog system preference set to 'Log'.
2) Import a file of bibliographic records with bulkmarcimport.pl.
3) Check the state of CataloguingLog system preference -- it will be
   set to 'Don't log'.
4) Apply the patch.
5) Repeat steps 1-3.  The CataloguingLog system preference
   will be 'Log'.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 5 Galen Charlton 2013-05-31 14:32:51 UTC
Pushed to master.  Thanks, Janusz!
Comment 6 Tomás Cohen Arazi 2013-06-10 17:19:28 UTC
This patch has been pushed to 3.12.x, will be in 3.12.1.
Thanks Janusz!
Comment 7 Bernardo Gonzalez Kriegel 2013-06-14 01:43:41 UTC
Pushed to 3.10.x, will be in 3.10.7
Comment 8 Chris Hall 2013-06-17 07:55:56 UTC
pushed to 3.8.x, will be in 3.8.14