The bulkmarcimport.pl script does not correctly restore the CataloguingLog system preference. To reproduce: 1) have CataloguingLog set to Log; 2) import some batch of bibliographic records with bulkmarcimport.pl 3) check the state of CataloguingLog system preference -- it will be set to "Don't log". A patch will follow.
Created attachment 18375 [details] [review] Proposed patch The patch corrects the issue.
Created attachment 18533 [details] [review] Bug 10326: bulkmarcimport.pl doesn't restore value of CataloguingLog syspref To test: 0) Don't apply the patch yet. 1) Have the CataloguingLog system preference set to 'Log'. 2) Import a file of bibliographic records with bulkmarcimport.pl. 3) Check the state of CataloguingLog system preference -- it will be set to 'Don't log'. 4) Apply the patch. 5) Repeat steps 1-3. The CataloguingLog system preference will be 'Log'. Signed-off-by: Galen Charlton <gmc@esilibrary.com>
sounds logical, marked as Passed QA.
Created attachment 18539 [details] [review] Bug 10326: bulkmarcimport.pl doesn't restore value of CataloguingLog syspref To test: 0) Don't apply the patch yet. 1) Have the CataloguingLog system preference set to 'Log'. 2) Import a file of bibliographic records with bulkmarcimport.pl. 3) Check the state of CataloguingLog system preference -- it will be set to 'Don't log'. 4) Apply the patch. 5) Repeat steps 1-3. The CataloguingLog system preference will be 'Log'. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Pushed to master. Thanks, Janusz!
This patch has been pushed to 3.12.x, will be in 3.12.1. Thanks Janusz!
Pushed to 3.10.x, will be in 3.10.7
pushed to 3.8.x, will be in 3.8.14