Bug 10334 - UT: t/db_dependent/needs_user_input/* are unusable
Summary: UT: t/db_dependent/needs_user_input/* are unusable
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Test Suite (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Jonathan Druart
QA Contact:
URL:
Keywords:
Depends on:
Blocks: 10273
  Show dependency treegraph
 
Reported: 2013-05-24 13:08 UTC by Jonathan Druart
Modified: 2014-12-07 20:02 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
MT10334: t/db_dependent/needs_user_input/* are unusable (4.14 KB, patch)
2013-05-24 13:10 UTC, Jonathan Druart
Details | Diff | Splinter Review
MT10334: t/db_dependent/needs_user_input/* are unusable (4.19 KB, patch)
2013-05-24 21:28 UTC, Chris Cormack
Details | Diff | Splinter Review
Bug 10334 - UT: t/db_dependent/needs_user_input/* are unusable (4.27 KB, patch)
2013-06-21 13:12 UTC, Kyle M Hall
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2013-05-24 13:08:38 UTC
t/db_dependent/needs_user_input/Auth.t and t/db_dependent/needs_user_input/Auth_with_ldap.t seem not really useful. If I refer to the git history, it seems that they are antiquated tests.

The first one is not compilable:
perl -wc t/db_dependent/needs_user_input/Auth.t
Can't locate override_context_prefs.pm
Comment 1 Jonathan Druart 2013-05-24 13:10:30 UTC Comment hidden (obsolete)
Comment 2 Chris Cormack 2013-05-24 21:23:36 UTC
Yes I concur these tests are not working. Having them there makes people think things are being tested when they aren't, happy to sign off on their removal.
Comment 3 Chris Cormack 2013-05-24 21:28:12 UTC Comment hidden (obsolete)
Comment 4 Kyle M Hall 2013-06-21 13:12:36 UTC
Created attachment 19186 [details] [review]
Bug 10334 - UT: t/db_dependent/needs_user_input/* are unusable

t/db_dependent/needs_user_input/Auth.t and
t/db_dependent/needs_user_input/Auth_with_ldap.t seem not really useful.
If I refer to the git history, it seems that they are antiquated tests.

The first one is not compilable:
perl -wc t/db_dependent/needs_user_input/Auth.t
Can't locate override_context_prefs.pm

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Comment 5 Galen Charlton 2013-06-21 14:35:00 UTC
Pushed to master.  Thanks, Jonathan!