Bug 10343 - Rename OpacShowHoldNotes to OpacHoldNotes
Summary: Rename OpacShowHoldNotes to OpacHoldNotes
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Hold requests (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial (vote)
Assignee: Marcel de Rooy
QA Contact: Jonathan Druart
URL:
Keywords:
Depends on: 10321
Blocks:
  Show dependency treegraph
 
Reported: 2013-05-27 08:20 UTC by Marcel de Rooy
Modified: 2014-12-07 20:02 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 10343: Rename OpacShowHoldNotes to OpacHoldNotes (8.19 KB, patch)
2013-05-27 08:40 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 10343: Rename OpacShowHoldNotes to OpacHoldNotes (5.83 KB, patch)
2013-05-29 14:34 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 10343: dbrev for rename OpacShowHoldNotes to OpacHoldNotes (2.76 KB, patch)
2013-05-29 14:34 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 10343: Rename OpacShowHoldNotes to OpacHoldNotes (5.83 KB, patch)
2013-05-29 14:34 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Bug 10343: dbrev for rename OpacShowHoldNotes to OpacHoldNotes (2.77 KB, patch)
2013-06-07 14:36 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 10343: Rename OpacShowHoldNotes to OpacHoldNotes (5.83 KB, patch)
2013-06-07 14:37 UTC, Kyle M Hall
Details | Diff | Splinter Review
Bug 10343: dbrev for rename OpacShowHoldNotes to OpacHoldNotes (2.83 KB, patch)
2013-06-07 14:53 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 10343: Rename OpacShowHoldNotes to OpacHoldNotes (5.96 KB, patch)
2013-06-07 14:53 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Marcel de Rooy 2013-05-27 08:20:53 UTC
As a QA followup on report 9722.
Jonathan suggested to move the pref. I suggested to rename.
Then Jonathan suggested: OpacHoldNotes is probably more expressive.

In the meantime I also discovered that this pref name came in two flavours: starting with OPAC and with Opac.
Unfortunately, there are a lot of prefs starting with OPAC, Opac or opac.
Since we are not consistent, I pick Opac for readability :)
Comment 1 Marcel de Rooy 2013-05-27 08:28:20 UTC
Building this on top of bug 10321. Please apply/test that one first :)
Comment 2 Marcel de Rooy 2013-05-27 08:40:14 UTC Comment hidden (obsolete)
Comment 3 Marcel de Rooy 2013-05-29 14:34:12 UTC Comment hidden (obsolete)
Comment 4 Marcel de Rooy 2013-05-29 14:34:28 UTC Comment hidden (obsolete)
Comment 5 Marcel de Rooy 2013-05-29 14:34:32 UTC Comment hidden (obsolete)
Comment 6 Marcel de Rooy 2013-05-29 14:36:31 UTC
Separated the dbrev from the other changes.
A merge conflict on the dbrev patch should not be hard to resolve :)

Please test them on top of bug 10321. Thanks.
Comment 7 Kyle M Hall 2013-06-07 14:36:59 UTC Comment hidden (obsolete)
Comment 8 Kyle M Hall 2013-06-07 14:37:05 UTC Comment hidden (obsolete)
Comment 9 Marcel de Rooy 2013-06-07 14:42:07 UTC
(In reply to comment #8)
> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Thanks.
Comment 10 Jonathan Druart 2013-06-07 14:52:54 UTC
git grep OpacShowHoldNotes returns 0 occurrence.

Marked as Passed QA.
Comment 11 Jonathan Druart 2013-06-07 14:53:24 UTC
Created attachment 18761 [details] [review]
Bug 10343: dbrev for rename OpacShowHoldNotes to OpacHoldNotes

Renames the pref for install and upgrade.

Test plan: See the other patch.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 12 Jonathan Druart 2013-06-07 14:53:28 UTC
Created attachment 18762 [details] [review]
Bug 10343: Rename OpacShowHoldNotes to OpacHoldNotes

As QA followup on report 9722. Built on top of another followup report 10321.

Test plan:
Run the db revision included in the other patch.
Enable OpacHoldNotes. Check that you can add a hold note on opac-reserve.
Do you see it on opac-user and in staff on catalog detail of that biblio?
Do a grep on ShowHoldNotes on the Koha code: grep -i ignores case. You should
find three occurrences only in updatedatabase.pl (the old dbrev and this dbrev
renaming them). These are fine.

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Comment 13 Galen Charlton 2013-06-07 17:07:30 UTC
Pushed to master.  Thanks, Marcel!