Bug 10349 - Don't show empty Descriptions/Title notes tabs in OPAC and staff
Summary: Don't show empty Descriptions/Title notes tabs in OPAC and staff
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Templates (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Owen Leonard
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-05-27 12:47 UTC by Katrin Fischer
Modified: 2014-12-07 20:02 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 10349 - Don't show empty Descriptions/Title notes tabs in OPAC and staff (3.58 KB, patch)
2013-05-31 16:09 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 10349 - Don't show empty Descriptions/Title notes tabs in OPAC and staff (3.60 KB, patch)
2013-07-27 18:57 UTC, Mirko Tietgen
Details | Diff | Splinter Review
[PASSED QA] Bug 10349 - Don't show empty Descriptions/Title notes tabs in OPAC and staff (3.81 KB, patch)
2013-08-25 19:35 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2013-05-27 12:47:56 UTC
In staff and OPAC detail pages we shouldn't show the tabs "Description" or "Title note" when they are empty.

Also - should they be named differently?
Comment 1 Owen Leonard 2013-05-31 16:09:42 UTC Comment hidden (obsolete)
Comment 2 Mirko Tietgen 2013-07-27 18:57:07 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2013-08-25 19:35:24 UTC
Created attachment 20604 [details] [review]
[PASSED QA] Bug 10349 - Don't show empty Descriptions/Title notes tabs in OPAC and staff

The descriptions/title notes tab appears on the detail page in both
staff client and OPAC even if there are no notes. This is probably a
relic of the pre-T:T days when it wasn't possible to use || in an IF.
This patch adds a check for the various variables which might trigger
the display of the tab.

To test, apply the patch and view records in the OPAC and staff client
which do and do not have title notes attached (whether that be in the
MARC reocrd or in the biblio.notes column). In the OPAC Syndetics
content should also be tested if possible. The descriptions/title notes
tab should only appear if there is content.

Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
That's better - thx Owen!
Works nicely and passes all tests.
Tested in staff and OPAC, also in combination with NotesBlacklist
hiding all notes.
Comment 4 Galen Charlton 2013-09-08 01:49:41 UTC
Pushed to master.  Thanks, Owen!
Comment 5 Tomás Cohen Arazi 2013-10-08 14:11:59 UTC
This patch has been pushed to 3.12.x, will be in 3.12.6.

Thanks Owen!