When using OpacAddMastheadLibraryPulldown the library pull down next to the simple search now allways shows an opt group 'libraries' before the entries for the libraries. For an installation with only a few libraries and no search groups this doesn't make sense. Also it would be good if the opt group heading could be formatted to make it more obvious that it's not an option that and can not be selected.
Created attachment 18544 [details] [review] Bug 10354 - Don't show optgroup Libraries when no search groups are defined In the OPAC, if there are no search groups defined, there's no reason to embed library choices inside an <optgroup>. <optgroup> should only be used to differentiate the list of individual libraries from search groups. This patch removes the <optgroup> when no search groups are enabled. To test, apply the patch and: - Enable OpacAddMastheadLibraryPulldown. - Create a library search group in Administration -> Libraries and Groups and enable it by checking the "show in search pulldown" box. - View the library pulldown in the OPAC search bar. Libraries and groups should be separated into <optgroup>s. - Disable your library search group and refresh the OPAC page. The pulldown of libraries should now display libraries with no <optgroup>.
Created attachment 18593 [details] [review] [Signed-Off] Bug 10354 - Don't show optgroup Libraries when no search groups are defined In the OPAC, if there are no search groups defined, there's no reason to embed library choices inside an <optgroup>. <optgroup> should only be used to differentiate the list of individual libraries from search groups. This patch removes the <optgroup> when no search groups are enabled. To test, apply the patch and: - Enable OpacAddMastheadLibraryPulldown. - Create a library search group in Administration -> Libraries and Groups and enable it by checking the "show in search pulldown" box. - View the library pulldown in the OPAC search bar. Libraries and groups should be separated into <optgroup>s. - Disable your library search group and refresh the OPAC page. The pulldown of libraries should now display libraries with no <optgroup>. Signed-off-by: Srdjan <srdjan@catalyst.net.nz>
QA comment: Simple patch. Works as described. Marked as Passed QA.
Created attachment 18732 [details] [review] Bug 10354 - Don't show optgroup Libraries when no search groups are defined In the OPAC, if there are no search groups defined, there's no reason to embed library choices inside an <optgroup>. <optgroup> should only be used to differentiate the list of individual libraries from search groups. This patch removes the <optgroup> when no search groups are enabled. To test, apply the patch and: - Enable OpacAddMastheadLibraryPulldown. - Create a library search group in Administration -> Libraries and Groups and enable it by checking the "show in search pulldown" box. - View the library pulldown in the OPAC search bar. Libraries and groups should be separated into <optgroup>s. - Disable your library search group and refresh the OPAC page. The pulldown of libraries should now display libraries with no <optgroup>. Signed-off-by: Srdjan <srdjan@catalyst.net.nz> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Created attachment 18735 [details] [review] [ALT] Bug 10354: Remove erroneous call to haspermission in basket.pl
Comment on attachment 18735 [details] [review] [ALT] Bug 10354: Remove erroneous call to haspermission in basket.pl Wrong report.
Pushed to master. Thanks, Owen!
This patch has been pushed to 3.12.x, will be in 3.12.1. Thanks Owen!