Bug 10396 - Catalog stats shows calendar in callnumber field
Summary: Catalog stats shows calendar in callnumber field
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Reports (show other bugs)
Version: master
Hardware: All All
: P3 minor (vote)
Assignee: Sophie MEYNIEUX
QA Contact:
URL:
Keywords:
Depends on: 8181
Blocks:
  Show dependency treegraph
 
Reported: 2013-06-03 13:18 UTC by Sophie MEYNIEUX
Modified: 2014-12-07 20:02 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 10396 : Because of "From" and "to" input field on callnumber, a datepicker is forced on those fields. (3.30 KB, patch)
2013-06-03 13:30 UTC, Sophie MEYNIEUX
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 10396 : Because of "From" and "to" input field on callnumber, a datepicker is forced on those fields. (3.40 KB, patch)
2013-06-05 15:27 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 10396 : Itemcallnumber and year of publication does not need datepicker fields in catalog stats form (2.02 KB, patch)
2013-06-10 13:34 UTC, Sophie MEYNIEUX
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 10396 : Itemcallnumber and year of publication does not need datepicker fields in catalog stats form (2.06 KB, patch)
2013-06-11 04:14 UTC, Srdjan Jankovic
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 10396 : Itemcallnumber and year of publication does not need datepicker fields in catalog stats form (2.37 KB, patch)
2013-06-16 08:51 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Sophie MEYNIEUX 2013-06-03 13:18:55 UTC
On Catalog statitics form, first field filters on callnumber, but because of "From" and "To" values, a calendar is displaid, and it is not possible to enter something different from a date.
Comment 1 Sophie MEYNIEUX 2013-06-03 13:22:30 UTC
This patch is a followup of BZ8181
Comment 2 Sophie MEYNIEUX 2013-06-03 13:30:19 UTC Comment hidden (obsolete)
Comment 3 Owen Leonard 2013-06-05 15:27:41 UTC Comment hidden (obsolete)
Comment 4 Jonathan Druart 2013-06-07 12:08:27 UTC
QA comment:

The patch does not work: both from and to inputs (for publication year) are changed when I choose a date.
To reproduce:
1/ Go on reports/catalogue_stats.pl
2/ Choose a from date OK
3/ Choose a to date KO: The from date is changed too

Marked as Failed QA.
Comment 5 Sophie MEYNIEUX 2013-06-10 13:34:57 UTC Comment hidden (obsolete)
Comment 6 Sophie MEYNIEUX 2013-06-10 13:36:11 UTC
New patch proposed because even publication year does not need to be a datepicker
Comment 7 Srdjan Jankovic 2013-06-11 04:14:51 UTC Comment hidden (obsolete)
Comment 8 Srdjan Jankovic 2013-06-11 04:16:03 UTC
That form is just diabolical.
Comment 9 Katrin Fischer 2013-06-16 08:51:57 UTC
Created attachment 19032 [details] [review]
[SIGNED-OFF] Bug 10396 : Itemcallnumber and year of publication does not need datepicker fields in catalog stats form

Signed-off-by: Srdjan <srdjan@catalyst.net.nz>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>

Removes datepickers from fields where they are not needed.
When the new datepickers were added Owen made them so they show
up when you use certain keywords in your markup. That's great, but
by accident this older form was affected.

Template only change.
Comment 10 Katrin Fischer 2013-06-16 08:53:02 UTC
I think Srdjan forgot to switch this to signed off :)
Comment 11 Katrin Fischer 2013-06-16 08:54:13 UTC
Just a note to the release maintainers: I have seen this problem in 3.10.2 as well.
Comment 12 Galen Charlton 2013-06-17 14:41:23 UTC
Pushed to master.  Thanks, Sophie!
Comment 13 Tomás Cohen Arazi 2013-07-07 00:08:34 UTC
This patch has been pushed to 3.12.x, will be in 3.12.2.

Thanks Sophie!
Comment 14 Bernardo Gonzalez Kriegel 2013-07-13 22:49:23 UTC
Pushed to 3.10.x, will be in 3.10.8