Right now there is no way to change the budget or fund when receiving an item, which is annoying, particularly at the end of the fiscal year when every item not already received has to be switched to the following year's budget. This development will add the ability to change the budget and fund when receiving.
Created attachment 19050 [details] [review] Bug 10403: add ability to change fund on receipt Right now there is no way to change the budget or fund when receiving an item, which is annoying, particularly at the end of the fiscal year when every item not already received has to be switched to the following year's budget. This patch adds the ability to change the budget and fund when receiving. To test: 1) Apply patch. 2) Create an order for a vendor, choosing a fund to use for that order. 3) Receive the order, leaving the fund unchanged. Make sure the fund did not change. 4) Create another order for a vendor, choosing a fund to use for that order. 5) Receive the order, this time changing the fund. Make sure the fund is changed. 6) Run the unit test: > prove t/db_dependent/Acquisition.t 7) Sign off. (Notes: this patch depends on the Acquisitions.t unit test improvements in bug 10274; the seemingly-unrelated change in SQLHelper quiets an irritating warning caused by the NewOrder call in ModReceiveOrder)
Created attachment 20298 [details] [review] Bug 10403: add ability to change fund on receipt Right now there is no way to change the budget or fund when receiving an item, which is annoying, particularly at the end of the fiscal year when every item not already received has to be switched to the following year's budget. This patch adds the ability to change the budget and fund when receiving. To test: 1) Apply patch. 2) Create an order for a vendor, choosing a fund to use for that order. 3) Receive the order, leaving the fund unchanged. Make sure the fund did not change. 4) Create another order for a vendor, choosing a fund to use for that order. 5) Receive the order, this time changing the fund. Make sure the fund is changed. 6) Run the unit test: > prove t/db_dependent/Acquisition.t 7) Sign off. (Notes: this patch depends on the Acquisitions.t unit test improvements in bug 10274; the seemingly-unrelated change in SQLHelper quiets an irritating warning caused by the NewOrder call in ModReceiveOrder)
Created attachment 20299 [details] [review] Bug 10403: Show inactive but unlocked budgets on orderreceive I have heard from several libraries that at the end of the budget year even though a budget is inactive for new acquisitions, an inactive budget should remain modifiable until the books are closed and the budget is marked inactive. This patch makes it so that all budgets that are unlocked are available on the order receipt page (only).
Thanks, it will very useful. Works as described, I sign off. One remark : on "invoice.pl" after the reception is done, there is a column "fund" in the table. Now that we can use a fund from an inactive budget, maybe we could add a column budget, or just give the name of the budget in parenthesis after the fund? (just an idea...) By the way, I think the table invoice.pl does not take into account the unitprice, but the ecost. That's bad... Mathieu
Created attachment 21101 [details] [review] [PATCH][SIGNED OFF] Bug 10403: add ability to change fund on receipt
Created attachment 21102 [details] [review] [PATCH][SIGNED OFF] Bug 10403: Show inactive but unlocked budgets on orderreceive I am fine with that,and it is working..., but maybe some libraries won't like the idea of using an inactive budget. Do you think it could be syspref dependant? Not sure it deserves it. Mathieu
QA comment: Works great. I tested some receives and results are consistent. The budgets dropdown list construction should really be factorized. Sometimes it is displayed with budgets, sometimes not. Sometimes a checkbox is there for displaying all funds, sometimes not. Marked as Passed QA.
Created attachment 21231 [details] [review] Bug 10403: add ability to change fund on receipt Right now there is no way to change the budget or fund when receiving an item, which is annoying, particularly at the end of the fiscal year when every item not already received has to be switched to the following year's budget. This patch adds the ability to change the budget and fund when receiving. To test: 1) Apply patch. 2) Create an order for a vendor, choosing a fund to use for that order. 3) Receive the order, leaving the fund unchanged. Make sure the fund did not change. 4) Create another order for a vendor, choosing a fund to use for that order. 5) Receive the order, this time changing the fund. Make sure the fund is changed. 6) Run the unit test: > prove t/db_dependent/Acquisition.t 7) Sign off. (Notes: this patch depends on the Acquisitions.t unit test improvements in bug 10274; the seemingly-unrelated change in SQLHelper quiets an irritating warning caused by the NewOrder call in ModReceiveOrder) Signed-off-by: Mathieu Saby <mathieu.saby@univ-rennes2.fr> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Created attachment 21232 [details] [review] Bug 10403: Show inactive but unlocked budgets on orderreceive I have heard from several libraries that at the end of the budget year even though a budget is inactive for new acquisitions, an inactive budget should remain modifiable until the books are closed and the budget is marked inactive. This patch makes it so that all budgets that are unlocked are available on the order receipt page (only). Signed-off-by: Mathieu Saby <mathieu.saby@univ-rennes2.fr> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Pushed to master. Thanks, Jared!